initialize duckdb_result->deprecated_columns to nullptr #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducing issue #257, the segfault was consistently occurring in the
duckdb_destroy_resulthereduckdb-node-neo/bindings/src/duckdb_node_bindings.cpp
Lines 881 to 895 in 2c30abb
Looking into what duckdby_destroy_result does: https://github.com/duckdb/duckdb/blob/879b0e72286b189a38b969214aa7a4e26cb64fff/src/main/capi/result-c.cpp#L498-L511
The theory is that because result->deprecated_columns is uninitialized in the caller and may contain arbitrary value. In the error path, deprecated_columns may never end up being initialized and will lead to duckdby_destroy_result trying to access the arbitrary address it holds.
Testing
The added unit test models after the repro script and was consistently crashing without this fix. With the fix it does not crash.