Add url-changed to WebTelemetry
#1865
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Thu, 31 Jul 2025 12:40:02 GMT Android
File has changed Apple
File has changed Chrome-mv3File has changed FirefoxFile has changed IntegrationFile has changed WindowsFile has changed |
|
Created a PR per conversation in https://app.asana.com/1/137249556945/project/1208228079594252/task/1210902731262343?focus=true |
|
I don't think the test failure is me, looks to be linting error in special pages https://github.com/duckduckgo/content-scope-scripts/actions/runs/16630449807/job/47058205000?pr=1865#step:7:1 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uses JK's suggestion to get at the event type.
If I add this to `urlChanged` (in web-telemetry.js) I see that neither of these are true, which confuses me. It may be that we need a check here, or perhaps this is working because the WebTelemetry feature is enabled and that's by design.
```js
console.log('WebTelemetry: URL changed', navigationType, this.getFeatureSettingEnabled('urlChanged'), this.getFeatureSettingEnabled('listenForUrlChanges'));
```
Co-authored-by: Jonathan Kingston <[email protected]>
Co-authored-by: Jonathan Kingston <[email protected]>
jonathanKingston
left a comment
jonathanKingston
left a comment
There was a problem hiding this comment.
Thanks for dealing with switching it over here! Thanks!
2 participants
Asana Task/Github Issue:
Description
Uses JK's suggestion to get at the event type.
If I add this to
urlChanged(in web-telemetry.js) I see that neither of these are true, which confuses me. It may be that we need a check here, or perhaps this is working because the WebTelemetry feature is enabled and that's by design.Testing Steps
N/A - tested by https://github.com/duckduckgo/windows-browser/pull/4527
Checklist
Please tick all that apply: