-
Notifications
You must be signed in to change notification settings - Fork 31
Ensure message correctness in extension #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Wed, 20 Aug 2025 11:11:36 GMT Android
File has changed Apple
File has changed Chrome-mv3File has changed FirefoxFile has changed IntegrationFile has changed WindowsFile has changed |
3de235f to
21fc401
Compare
dharb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
* Ensure we check isFeatureEnabled correctly * Only trigger updates on listenForUpdateChanges enabled features (CTL) * Add bail out option for invalid messages
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1201614831475344/task/1211099580633727?focus=true
Fixes: #1900
Description
I think this issue is due to tab restoration in the service worker mv3 handling code in Firefox code only and only when the extension is updated (hence a new bout of reproductions).
I've done the following:
enabledFeaturesmissing, so we just shouldn't risk breaking the page.isFeatureBrokenmethod which would have prevented this exact issue.enabledFeaturescase in this method.As a perf benefit:
listenForUpdateChangesTesting Steps
Checklist
Please tick all that apply: