Skip to content

Conversation

@noisysocks
Copy link
Contributor

@noisysocks noisysocks commented Sep 11, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/414235014887631/task/1211321283124288?focus=true

Description

Fixes shadow rendering issue when hovering over the Customize link in WebKit.

Testing Steps

  1. Visit https://deploy-preview-1958--content-scope-scripts.netlify.app/build/pages/new-tab/?omnibar=true&omnibar.showCustomizePopover=true in a WebKit browser
  2. Mouse over the blue Customize link in the popover

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@noisysocks noisysocks requested review from a team, mgurgel and shakyShane as code owners September 11, 2025 01:06
@noisysocks noisysocks added the bug Something isn't working label Sep 11, 2025
@netlify
Copy link

netlify bot commented Sep 11, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 37cd55e
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68c25cb15d2edc0008e0df64
😎 Deploy Preview https://deploy-preview-1958--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

[Beta] Generated file diff

Time updated: Thu, 11 Sep 2025 05:23:52 GMT

Apple
    - apple/pages/new-tab/dist/index.css

File has changed

Integration
    - integration/pages/new-tab/dist/index.css

File has changed

Windows
    - windows/pages/new-tab/dist/index.css

File has changed

Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the LLM helper script thing separate thing so it can be discussed

@noisysocks
Copy link
Contributor Author

noisysocks commented Sep 11, 2025

Sorry, didn’t mean to include my CLAUDE.md :) (though I do keep meaning to clean it up and propose it as an AGENTS.md)

@noisysocks noisysocks force-pushed the randerson/fix-webkit-shadow-rendering-issue branch from 337ad3a to 37cd55e Compare September 11, 2025 05:22
@noisysocks noisysocks added this pull request to the merge queue Sep 11, 2025
@noisysocks noisysocks removed this pull request from the merge queue due to a manual request Sep 11, 2025
@noisysocks noisysocks added this pull request to the merge queue Sep 11, 2025
Merged via the queue into main with commit c33e7b2 Sep 11, 2025
18 checks passed
@noisysocks noisysocks deleted the randerson/fix-webkit-shadow-rendering-issue branch September 11, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants