Skip to content

Conversation

@jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Sep 11, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1201520793593668/task/1211141698856303?focus=true

Description

  • Change telemetry into two events attach and send.
  • Round by 100s for the bucketing.
  • Use absolute values for pings instead of bucketing.
  • Fix key event on keydown to prevent being swallowed by react.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@netlify
Copy link

netlify bot commented Sep 11, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 9a795e2
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68c82c733174b80009a7df7f
😎 Deploy Preview https://deploy-preview-1962--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

[Beta] Generated file diff

Time updated: Mon, 15 Sep 2025 15:11:27 GMT

Apple
    - apple/contentScope.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

@jonathanKingston jonathanKingston marked this pull request as ready for review September 12, 2025 00:09
@jonathanKingston jonathanKingston requested a review from a team as a code owner September 12, 2025 00:09
@jonathanKingston jonathanKingston added this pull request to the merge queue Sep 15, 2025
Merged via the queue into main with commit 3ce385b Sep 15, 2025
17 checks passed
@jonathanKingston jonathanKingston deleted the jkt/page-telemetry branch September 15, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants