Skip to content

Conversation

@vkraucunas
Copy link
Contributor

@vkraucunas vkraucunas commented Oct 17, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/42792087274227/task/1211403383853083?focus=true

Description

Adding a Subscription variant to the NextSteps cards
Updating the URL params docs

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Adds a new subscription Next Steps card and wires it into schema/types, translations, icon assets, and NTP URL parameter docs.

  • Next Steps:
    • Add subscription variant in app/next-steps/nextsteps.data.js with icon Subscription and texts.
    • Extend messages/types/next-steps.json and types/new-tab.ts to include subscription.
    • Add translations for subscription in base strings and locales (de, en, es, fr, it, nl, pl, pt, ru).
    • Add icon asset special-pages/pages/new-tab/public/icons/Subscription-128.svg.
  • Docs:
    • Update readme.md to document Next Steps URL param (including subscription) and Freemium PIR banner; remove duplicate/old experiment section.

Written by Cursor Bugbot for commit c843128. This will update automatically on new commits. Configure here.

@vkraucunas vkraucunas requested review from a team, mgurgel and shakyShane as code owners October 17, 2025 17:38
@netlify
Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit c843128
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68f84563c54ca400084634f2
😎 Deploy Preview https://deploy-preview-2019--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

[Beta] Generated file diff

Time updated: Wed, 22 Oct 2025 02:47:01 GMT

Apple
    - apple/pages/new-tab/dist/index.js
  • apple/pages/new-tab/locales/de/new-tab.json
  • apple/pages/new-tab/locales/en/new-tab.json
  • apple/pages/new-tab/locales/es/new-tab.json
  • apple/pages/new-tab/locales/fr/new-tab.json
  • apple/pages/new-tab/locales/it/new-tab.json
  • apple/pages/new-tab/locales/nl/new-tab.json
  • apple/pages/new-tab/locales/pl/new-tab.json
  • apple/pages/new-tab/locales/pt/new-tab.json
  • apple/pages/new-tab/locales/ru/new-tab.json

File has changed

Integration
    - integration/pages/new-tab/dist/index.js
  • integration/pages/new-tab/locales/de/new-tab.json
  • integration/pages/new-tab/locales/en/new-tab.json
  • integration/pages/new-tab/locales/es/new-tab.json
  • integration/pages/new-tab/locales/fr/new-tab.json
  • integration/pages/new-tab/locales/it/new-tab.json
  • integration/pages/new-tab/locales/nl/new-tab.json
  • integration/pages/new-tab/locales/pl/new-tab.json
  • integration/pages/new-tab/locales/pt/new-tab.json
  • integration/pages/new-tab/locales/ru/new-tab.json

File has changed

Windows
    - windows/pages/new-tab/dist/index.js
  • windows/pages/new-tab/locales/de/new-tab.json
  • windows/pages/new-tab/locales/en/new-tab.json
  • windows/pages/new-tab/locales/es/new-tab.json
  • windows/pages/new-tab/locales/fr/new-tab.json
  • windows/pages/new-tab/locales/it/new-tab.json
  • windows/pages/new-tab/locales/nl/new-tab.json
  • windows/pages/new-tab/locales/pl/new-tab.json
  • windows/pages/new-tab/locales/pt/new-tab.json
  • windows/pages/new-tab/locales/ru/new-tab.json

File has changed

New Files
    - apple/pages/new-tab/icons/Subscription-128.svg
  • integration/pages/new-tab/icons/Subscription-128.svg
  • windows/pages/new-tab/icons/Subscription-128.svg

❌ File only exists in new changeset

cursor[bot]

This comment was marked as outdated.

@vkraucunas vkraucunas force-pushed the vkraucunas/subscription-nextsteps-card branch from 9864d99 to c843128 Compare October 22, 2025 02:45
@shakyShane shakyShane added this pull request to the merge queue Oct 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2025
@shakyShane shakyShane added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit 7342634 Oct 22, 2025
18 checks passed
@shakyShane shakyShane deleted the vkraucunas/subscription-nextsteps-card branch October 22, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants