Update existing-project.md #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing step
7-zete-7
reviewed
Jun 25, 2025
There was a problem hiding this comment.
I think it's better not to separate the steps "Re-execute the recipes to update the Docker-related files according to the packages you use" and "Double-check the changes, revert the changes that you don't want to keep" (they may contain a lot of changes and/or conflicts from Symfony Flex's work). How about adding this step after the step "Double-check the changes, revert the changes that you don't want to keep"?
Swap step order according to @7-zete-7's suggestion Various spelling
7-zete-7
reviewed
Jun 25, 2025
docs/existing-project.md
Outdated
| > [!NOTE] | ||
| > The worker mode of FrankenPHP is enabled by default in the Caddyfile. To disabled it, comment the `worker {}` section of this file. | ||
| > You may also remove `runtime/frankenphp-symfony` if you never play on using the worker mode. |
There was a problem hiding this comment.
My bad, silly typo!
7-zete-7
approved these changes
Jun 25, 2025
maxhelias
reviewed
Jul 2, 2025
Co-authored-by: Maxime Helias <[email protected]>
maxhelias
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing step