Skip to content

add support for 'download_instructions' easyconfig parameter key to specify some download or installation steps for user in case of complicated way of obtaining needed files #3976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 16, 2022
Merged

add support for 'download_instructions' easyconfig parameter key to specify some download or installation steps for user in case of complicated way of obtaining needed files #3976

merged 13 commits into from
Mar 16, 2022

Conversation

ItIsI-Orient
Copy link
Contributor

(created using eb --new-pr)

Orient and others added 4 commits March 8, 2022 16:19
@ItIsI-Orient ItIsI-Orient marked this pull request as draft March 8, 2022 16:04
@ItIsI-Orient ItIsI-Orient marked this pull request as ready for review March 8, 2022 16:42
@ItIsI-Orient ItIsI-Orient mentioned this pull request Mar 9, 2022
Merged
bartoldeman
bartoldeman requested changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

However we do require a test for new options, so that'll need to be added.

@boegel boegel added this to the 4.x milestone Mar 15, 2022
@boegel boegel force-pushed the 20220308161919_new_pr_HyjCenCVwv branch from c1624f6 to 16f55f8 Compare March 15, 2022 19:26
bartoldeman
bartoldeman approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartoldeman bartoldeman merged commit 245151a into easybuilders:develop Mar 16, 2022
@boegel
Copy link
Member

boegel commented Mar 16, 2022

@ItIsI-Orient Please also write up a small section on the use of download_instructions in the documentation, probably a small additional subsection under https://docs.easybuild.io/en/latest/Writing_easyconfig_files.html#source-files-patches-and-checksums makes most sense.

@boegel boegel changed the title Added new parameter key to specify some download or installation steps for user in case of complicated way of obtaining needed files support 'download_instructions' easyconfig parameter key to specify some download or installation steps for user in case of complicated way of obtaining needed files Mar 16, 2022
@boegel boegel modified the milestones: 4.x, next release (4.5.4) Mar 25, 2022
@boegel boegel changed the title support 'download_instructions' easyconfig parameter key to specify some download or installation steps for user in case of complicated way of obtaining needed files add support for 'download_instructions' easyconfig parameter key to specify some download or installation steps for user in case of complicated way of obtaining needed files Mar 29, 2022
@ItIsI-Orient ItIsI-Orient mentioned this pull request Apr 4, 2022
Merged
@Louwrensth Louwrensth mentioned this pull request May 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ItIsI-Orient @boegel @bartoldeman