Skip to content

Conversation

@juankamilo
Copy link

@juankamilo juankamilo commented Nov 17, 2020

Debit Card Feature

At the moment the default library doesn't have the complete implementation for Debit Cards.
Some validations of the fields that must be sent use the Credit Card model, so the transactions fail
We send our implementation, in case it helps you

Added Debit Card feature 
At the moment the default library doesn't have the implementation for Debit Cards, We will send the implementation request.
@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #181 (bdb40d4) into master (cec91fe) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   98.21%   98.24%   +0.02%     
==========================================
  Files          58       59       +1     
  Lines        1067     1081      +14     
==========================================
+ Hits         1048     1062      +14     
  Misses         19       19              
Impacted Files Coverage Δ
src/Services/Adapters/DebitCardPaymentAdapter.php 100.00% <100.00%> (ø)
src/Services/Gateways/DebitCard.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec91fe...bdb40d4. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

Merging #181 (c472e66) into master (f556691) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #181      +/-   ##
============================================
+ Coverage     97.65%   97.68%   +0.03%     
- Complexity      366      368       +2     
============================================
  Files            71       72       +1     
  Lines          1064     1078      +14     
============================================
+ Hits           1039     1053      +14     
  Misses           25       25              
Impacted Files Coverage Δ
src/Services/Adapters/DebitCardPaymentAdapter.php 100.00% <100.00%> (ø)
src/Services/Adapters/PaymentAdapter.php 98.38% <100.00%> (+0.02%) ⬆️
src/Services/Gateways/DebitCard.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f556691...c472e66. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants