How to Properly Close the Welcome View and Its Layout?

[hithisispolarbear]

Hi team,
Is there a recommended way to completely close the Welcome view, including its layout?
It seems that while the Welcome view itself is closed, its layout remains active, causing the ChatView to occupy the entire area previously used by the Welcome view.

Issue Details

1. Clicking the button:
   As the code shown below, it will close the welcome view and show the current perspective and then open chat view.
   
2. Welcome view closes, but layout persists:
   The ChatView appears in the layout area of the Welcome view, rather than in the expected perspective layout.
   
3. Perspective info from logs:
   The result of getPerspective() is JavaPerspective, which is correct. (However, the Java perspective is not shown in the foreground.)
   

Expected Behavior

We’d like the Welcome view and its layout to be fully closed, so that the normal perspective layout is restored and the ChatView appears in its intended position rather than occupy the entire area.

Below is the current implementation triggered on button press:

      continueButton.addMouseListener(new MouseAdapter() {
        @Override
        public void mouseDown(MouseEvent e) {
          close();
          
          IWorkbench workBench = PlatformUI.getWorkbench();

          // Close the Eclipse welcome view if it's open
          IIntroPart introPart = workBench.getIntroManager().getIntro();
          if (introPart != null) {
            workBench.getIntroManager().closeIntro(introPart);
          }
          
          // Open Chat view in the current perspective
          try {
            IWorkbenchWindow activeWorkbenchWindow = workBench.getActiveWorkbenchWindow();
            if (activeWorkbenchWindow != null) {
              IWorkbenchPage activePage = activeWorkbenchWindow.getActivePage();
              if (activePage != null) {
                IPerspectiveDescriptor activePerspective = activePage.getPerspective();
                if (activePerspective != null) {
                  // If there's an active page, just show the chat view in the current perspective
                  activePage = workBench.showPerspective(activePerspective.getId(), activeWorkbenchWindow);
                  activePage.showView("com.microsoft.copilot.eclipse.ui.chat.ChatView");
                  CopilotCore.LOGGER.info("Showing chat view in current perspective: " 
                      + activePerspective.getId());
                }
              }
            }
          } catch (WorkbenchException ex) {
            CopilotCore.LOGGER.error("Failed to show view after closing intro", ex);
          }
        }
      });

[merks]

The behavior might change if the part within the try is done via an asyncExec so that the workbench has a chance to restore the state because I do expect that normally closing the intro part. I don't think the showPerspective call is needed.

          workBench.getDisplay().asyncExec(() -> {...});

[iloveeclipse]

I don't think the showPerspective call is needed.

Correct, this seem to be wrong. Just running the code after closing the intro in async exec should be enough
activePage.showView("com.microsoft.copilot.eclipse.ui.chat.ChatView");

[hithisispolarbear]

Thank you both, @merks and @iloveeclipse .
Using asyncExec resolved the issue, and you're right—showPerspective isn't necessary. Everything is working fine now.
https://github.com/microsoft/copilot-eclipse/pull/975

      continueButton.addMouseListener(new MouseAdapter() {
        @Override
        public void mouseDown(MouseEvent e) {
          close();
          
          IWorkbench workBench = PlatformUI.getWorkbench();

          // Close the Eclipse welcome view if it's open
          IIntroPart introPart = workBench.getIntroManager().getIntro();
          if (introPart != null) {
            workBench.getIntroManager().closeIntro(introPart);
          }
          
          // Open the Copilot chat view
          workBench.getDisplay().asyncExec(() -> {
            try {
              workBench.getActiveWorkbenchWindow().getActivePage().showView(Constants.CHAT_VIEW_ID);
            } catch (PartInitException ex) {
              CopilotCore.LOGGER.error("Failed to open chat view", ex);
            }
          });
        }
      });