Add feature for exposing mock implementations #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "test-util" feature has been added which exposed the mockall based mock implementations of the transport and communication level API traits. These can be helpful to e.g. crates implementing UTransport for implementing unit tests.
sophokles73
force-pushed
the
make_mock_transport_public
branch
from
31f0491 to
301f7b8
Compare
PLeVasseur
approved these changes
Nov 18, 2024
Contributor
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
LGTM
All-in-all seems reasonable :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "test-util" feature has been added which exposed the mockall based
mock implementations of the transport and communication level API
traits. These can be helpful to e.g. crates implementing UTransport
for implementing unit tests.
Addresses #185