Add support for mapping messages to CloudEvents #216
Conversation
AnotherDaniel
left a comment
AnotherDaniel
left a comment
There was a problem hiding this comment.
One question, about copying the cloudevents.proto definition into this repo.
There was a problem hiding this comment.
Do we really want to pull this in as a copy? Or maybe revive the download&compile functionality we originally used in build.rs for external proto files?
There was a problem hiding this comment.
I would rather keep it in our source tree. It is a tagged version (i.e. immutable) and only a single file ...
There was a problem hiding this comment.
Mh. I'll defer to your judgement on this :) Would it make sense to mention this in NOTICE.md?
There was a problem hiding this comment.
Good idea, will do.
sophokles73
force-pushed
the
add_support_for_protobuf_cloudevents
branch
from
8d38738 to
50089cf
Compare
|
@AnotherDaniel would you mind taking another look? |
Added support for mapping UMessages to/from CloudEvents using Protobuf format.
sophokles73
force-pushed
the
add_support_for_protobuf_cloudevents
branch
from
50089cf to
5e22fff
Compare
|
@AnotherDaniel I have updated the NOTICE.md file accordingly. |
2 participants
Added support for mapping UMessages to/from CloudEvents using Protobuf format.
Addresses #203