Fix handling of payload format #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UMessage::extract_protobuf function has still handled both UPAYLOAD_FORMAT_PROTOBUF_WRAPPED_IN_ANY and UPAYLOAD_FORMAT_UNSPECIFIED synonymously. This has been changed to only support the former payload format as well as UPAYLOAD_FORMAT_PROTOBUF when extracting protobuf payload. Fixes eclipse-uprotocol#259
sophokles73
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UMessage::extract_protobuf function has still handled both
UPAYLOAD_FORMAT_PROTOBUF_WRAPPED_IN_ANY and UPAYLOAD_FORMAT_UNSPECIFIED
synonymously. This has been changed to only support the former payload
format as well as UPAYLOAD_FORMAT_PROTOBUF when extracting protobuf
payload.
Fixes #259