Add convenience accessors to UAttributes #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The accessors present in UMessage have been added to UAttributes as well because some L2 API passes UAttributes around without the full UMessage.
sophokles73
force-pushed
the
add_convenience_functions
branch
from
8fe3fb5 to
b50ccd9
Compare
AnotherDaniel
approved these changes
Oct 21, 2025
Contributor
AnotherDaniel
left a comment
AnotherDaniel
left a comment
There was a problem hiding this comment.
Looking good. The name type_() feels a bit jarring to read, but it appears we've had that some time already on UMessage - and UMessage::message_type() does also feel redundant. So I guess I can't really come up with anything better...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accessors present in UMessage have been added to UAttributes
as well because some L2 API passes UAttributes around without
the full UMessage.