Skip to content

Fixes for advisable app #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2021
Merged

Fixes for advisable app #57

merged 4 commits into from
Aug 5, 2021

Conversation

notthatjen
Copy link
Member

@notthatjen notthatjen commented Aug 5, 2021 •
edited
Loading

  • remove dom purifier
  • add fallback to useGetChunk
  • class vs className on renderChunk

@notthatjen notthatjen changed the base branch from master to new_improvements August 5, 2021 06:34
@notthatjen notthatjen merged commit 538fa01 into new_improvements Aug 5, 2021
notthatjen added a commit that referenced this pull request Aug 16, 2021
@notthatjen
Adjustments for Ruby Compatibility with MagicEditor (#58)
eeda3c1 
* Add fixes

* Fixes for advisable app (#57)

* Remove classes in collection template

* Remove dompurifier

* use className instead of class

* Update magic-editor version

* add react-dom to dependencies

* Fix sanitizeHTML issue

* remove yarn.lock

* ignore yarn lock, dist

* Use magic editor recent version

* fix collection template

* Use magic editor canary

* Puse magic editor v1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@notthatjen