Upgrade to 0.29.0 #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0.22 - Ridgy Didge
…n.GetRedirect methods
…-checks-in-fsharp Rewrite LINQPad samples checks in F#
Spring cleaning
tests refined removed unsed usings
trying to get the build not to hang on Mac OS
…0 confusion (octokit#1713) * force the implicit netstandard package version to 1.6.0 to avoid automated update to 1.6.1 which prevents strict netcoreapp1.0 support (required in aws lambda) * tidy up project files
* Added UpdatedAt property to Milestone. * Trying to find where travis moved our cheese
* Add pagination support to ReferencesClient. * Add missing unit tests for ReferencesClient * Add integration tests for ReferencesClient pagination. * Refactor assertion.
* Add ApiOptions overloads to repository invitations. * Remove ExcludeFromPaginationApiOptionsConvention for RepositoryInvitationsClient * Adjust tests to new call form. * Add null check and null check test for RepositoryInvitations. * Add integration tests draft. * Remove redundant using. * Replace Octocat with dual account test second user. * Fix mass repository creation by making it synchronous and fix last RepositoryInvitationsClient test utilizing Octokit user. * Refactor async hack. * Reduce number of created test repos.
…ctokit#1726) * Add more test cases for GetGitHubLoginUrl tests * Fix enterprise authorize Urls by replacing the existing relative Uri segment (/api/v3) instead of appending to it via an extension method * Add tests for new ReplaceRelativeUri extension method * add test for GHE URL on oauth CreateAccessToken * move away from class level consts * Oauth client can store stripped base URL so it works with GHE
* added support for StatusEventPayload * Added test for StatusEventPayload and fixed serializer to return that event payload type.
* added support for DateTime serialized as FileTime * changed non-iso timestamp deserialization from FromFileTime to FromUnixTime. * updated a test to also test the new time stamp deserializer. * moved all tests projects to a solution folder of their own. * Fixed test and added a missing field to Account. * Use original values in test. * Moved UpdatedAt from Account to User.
…t in order to capture pull_request_review_id (octokit#1739)
* Implement GetLicenseContents() method for getting repository's license info * Request License Preview API for calls that return Repository object. * Add missing accept headers to observable methods for ObservableRepositoriesClients * fix impacted unit tests
* Improve Rate Limits' Documentation I added an example about client.Miscellaneous.GetRateLimits(). * Update getting-started.md * Update getting-started.md * Update getting-started.md * Update getting-started.md * Update getting-started.md
* add NET Core * Remove explicit platforms and link to .NET STandard
…for clarity (octokit#1751) * Updated GitHubClient.cs XML Docs to match dev docs. * Updated Connection.cs XML Docs to match dev docs. * Updated ProductHeaderValue.cs XML Docs to match GitHub dev docs. * Updated EnterpriseProbe.cs XML Docs to match GitHub dev docs. * Updated GitHubClient.cs XML Docs to match GitHub dev docs, corrected grammar issue. * Updated Connection.cs XML Docs to match GitHub dev docs, corrected grammar issue. * Updated ProductHeaderValue.cs XML Docs to match GitHub dev docs, corrected grammar issue. * Removed my tabs, replaced with spaces to match format. * Removed tabs again * There seems to be some kind of bug where tabs are being shown though my local editor show none, so I'm submitting a bug to GitHub.com and editing in-browser to fix. * Update GitHubClient.cs * There seems to be some kind of bug where tabs are being shown though my local editor show none, so I'm submitting a bug to GitHub.com and editing in-browser to fix. * Update Connection.cs * There seems to be some kind of bug where tabs are being shown though my local editor show none, so I'm submitting a bug to GitHub.com and editing in-browser to fix. * Change a couple of tabs to spaces * tabs to spaces * tabs to spaces
…ctokit#1758) * Add Tls1.2 to allowed protocols, for earlier target frameworks where this wasnt already the default. ServicePointManager class used to do this, is only available in the full framework, so a preprocessor constant needs to be used * intergration tests net452 target wasn't setup * Use OR Assignment operator, just for Haacked
* add deserializer tests for nullable enums, StringEnum and nullable StringEnum properties * Fix deserializing nullable structs by using the underlying type when nullable * StringEnum<T> should behave like an enum, returning default(T) when it is uninitialised/null/blank * Don't allow null to be passed into StringEnum ctor - if it needs to be null then it should be declared as nullable * fix expected json * move logic to determine if property is a StringEnum<T> into helper function * serializer needs to treat StringEnum<T> specially by serializing the enum value according to existing serializer strategy (parameter attributes and so on) * remove fallback to default(T) * add test to assert ctor throws exception when null passed in * remove test for default(T) fallback behaviour * Fix exception in serializer test - StringEnum property must be initialized otherwise an exception is thrown when attempting to serialize * Dont allow empty strings either
* Implement PullRequest.MergeableState property * Tweak convention tests as they were being confused thinking the nullable StringEnum was a model class
* Added visibility field to EmailAddress response model * quote private in comment to indicate string value * Create EmailVisibility enum; change visibility to be StringEnum<EmailVisibility> * Change EmailVisibility to be nullable, remove null option from enum * Fixed closing tag on Visibility property summary * unskip email integration test as it seems to work now
* Add release notes * Fix failing integration test * Run FormatCode build task to tidy up whitespace * Remove "UnkownUser" from release notes contributors
Conflicts: Octokit.Reactive/Octokit.Reactive.csproj Octokit.Reactive/packages.config Octokit/Models/Response/PullRequest.cs Octokit/Octokit.csproj Octokit/Properties/AssemblyInfo.cs
Also VS changed Octokit's ProjectGuid, don't know why.
It's now needed by Connection.
shana
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge octokit 0.29.0 into GHfVS branch.
Deprecates #2, #3