Skip to content

Conversation

shanoaice
Copy link
Collaborator

Changes:

  • Rename sao.js to saofile.js and updates it to the newest SAO v1 format
  • Use EJS templating instead of Handlebars (seem like SAO v1 does not support any templates other than EJS)

@egoist When I test this with my latest SAO locally, there will always be an error while processing gitInit -- like this:

error TypeError: Cannot read property 'outDir' of undefined
    at gitInit (/home/andy/.config/yarn/global/node_modules/sao/lib/GeneratorContext.js:50:17)
    at GeneratorContext.completed (/d/vuepack/saofile.js:67:5)
    at SAO.runGenerator (/home/andy/.config/yarn/global/node_modules/sao/lib/index.js:128:30)
    at async SAO.run (/home/andy/.config/yarn/global/node_modules/sao/lib/index.js:101:5)

I don't know why, but everything else is fine.

@shanoaice shanoaice requested a review from egoist February 13, 2020 02:38
@shanoaice
Copy link
Collaborator Author

There is a workaround about the problem -- bind the Generator instance manually will solve the problem -- shipping it to this branch soon.

@shanoaice
Copy link
Collaborator Author

Also, the Vue CLI init (v2 legacy method) tools uses handlebars which is incompatible with the EJS template, so I will remove meta.json and drop the deprecated Vue CLI init support.

@shanoaice
Copy link
Collaborator Author

@egoist

@shanoaice
Copy link
Collaborator Author

I also need to publish this to a new package -- sao-vuepack to adapt to the SAO v1 generator naming. I will add you as a collaborator on that package @egoist.

KsRyY added 2 commits February 16, 2020 15:24
@shanoaice
Copy link
Collaborator Author

I decided to switch back to the Handlebars template and put back Vue CLI support. Everything will be released in [email protected].

@shanoaice shanoaice merged commit 7ae07d4 into master Feb 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the ksryy-dev branch February 16, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant