Plugging in Pulsecombiner and Pulsenoise for BIC #2076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: calorimetry
mhkim-anl
requested review from
mariakzurek,
simonge,
sly2j,
veprbl and
wdconinc
for more information, see https://pre-commit.ci
Contributor
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/17684050541. Please merge this PR into the branch `2075-plugging-in-pulsecombiner-and-pulsenoise-for-bic` to resolve failures in PR #2076. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
veprbl
reviewed
Sep 15, 2025
mhkim-anl
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
Author
|
Based on the Slides presented at the simulation meeting, the followings were updated.
In the slides, it is expected that this PR reduces the data size even though the BIC pulse data types are added, but I added one more pulse data, |
veprbl
deleted the
2075-plugging-in-pulsecombiner-and-pulsenoise-for-bic
branch
wdconinc
reviewed
Oct 17, 2025
| "EcalBarrelScFiPAttenuatedHitContributions", | ||
| "EcalBarrelScFiNAttenuatedHits", | ||
| "EcalBarrelScFiNAttenuatedHitContributions", | ||
| "EcalBarrelScFiRawHits", |
Contributor
There was a problem hiding this comment.
What was the reason for removing EcalBarrelScFiRawHits here???
Contributor
Author
There was a problem hiding this comment.
I'm sorry for the late reply. I was attending the DNP. I thought we use EcalBarrelScFiRecHits rather than EcalBarrelScFiRawHits when we analyze the eicrecon output. I also thought EcalBarrelScFiRawHits would be replaced by a new RawHGCROCHit once the digitization algorithm is implemented. So I excluded it from the default output to reduce the size of the BIC output.
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
### Briefly, what does this PR introduce? This PR re-adds the EcalBarrelScFiRawHits and associations to the output, after they were removed in #2076. ### What kind of change does this PR introduce? - [x] Bug fix (issue: regression when used outputs were removed) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? Restore outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR is to plug in PulseCombiner and PulseNoise for BIC. For the PulseCombiner, pulses from different particles were combined for each SiPM channel. For the PulseNoise, a specific pedestal distribution was reproduced so that it gives the same pedestal mean and sigma when the amplitudes are measured every 25 ns. To reproduce the specific pedestal model, an offset was added to the
PulseNoiseConfig.h. Since the order of the arguments in theFalphaNoisewas swapped, it was modified.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?