EcalBarrelScFiRecHits: Modify localDetFields and distance parameters #2139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "sector" to CalorimeterHitReco_factory::localDetectorFields for EcalBarrelScFiRecHits so that EcalBarrelScFiRecHits will have local coordinates in sector frame of reference. With this, Island Clustering for EcalBarrelScFiProtoClusters works as expected when it is based on the localDistXZ
github-actions
bot
added
topic: calorimetry
for more information, see https://pre-commit.ci
Contributor
Author
|
The comparison plots for the ScFiRecHit positions are in the attached pdf. |
Contributor
Contributor
7 tasks
wdconinc
changed the title
AkshayaVijay
temporarily deployed
to
github-pages
GitHub Actions
Inactive
AkshayaVijay
temporarily deployed
to
github-pages
GitHub Actions
Inactive
AkshayaVijay
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mariakzurek
approved these changes
Oct 28, 2025
wdconinc
approved these changes
Oct 29, 2025
AkshayaVijay
temporarily deployed
to
github-pages
GitHub Actions
Inactive
wdconinc
deleted the
Add-sector-to-EcalBarrelScFiRecHits-localDetFields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Added "sector" to CalorimeterHitReco_factory::localDetectorFields for EcalBarrelScFiRecHits so that EcalBarrelScFiRecHits will have local coordinates in sector frame of reference.
With this, Island Clustering for EcalBarrelScFiProtoClusters works as expected when it is based on the localDistXZ
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Local coordinate for ScFiRec hits will be in sector frame of reference