Skip to content

Migrate to sdk v2 - configuration loading #6432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 4, 2023
Merged

Migrate to sdk v2 - configuration loading #6432

merged 9 commits into from
Jul 4, 2023

Conversation

TiberiuGC
Copy link
Contributor

@TiberiuGC TiberiuGC commented Mar 14, 2023 •
edited
Loading

Description

Closes #6276
Closes #5765

Previously blocked by aws/amazon-ec2-instance-selector#158, now closed.

Still to be done

  • Update references to ec2 instance selector once they migrate to sdk v2
  • Update unit tests accordingly
  • Remove no longer used code from filecache.go
  • run integration tests suite against this branch
  • rebase and solve dependencies conflicts

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@github-actions github-actions bot added the stale label Apr 14, 2023
@Himangini Himangini added technical debt blocked/tech-debt area/tech-debt Leftover improvements in code, testing and building and removed stale labels Apr 14, 2023
@github-actions github-actions bot added the stale label May 15, 2023
@github-actions github-actions bot closed this May 21, 2023
@TiberiuGC TiberiuGC reopened this May 22, 2023
@github-actions github-actions bot removed the stale label May 23, 2023
@TiberiuGC TiberiuGC marked this pull request as ready for review June 30, 2023 08:16
@TiberiuGC TiberiuGC requested review from Himangini and cPu1 June 30, 2023 08:17
@TiberiuGC TiberiuGC enabled auto-merge (squash) July 4, 2023 05:54
@TiberiuGC TiberiuGC merged commit 38d294b into eksctl-io:main Jul 4, 2023
idanshoham95 pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Jul 26, 2023
@TiberiuGC
Migrate to sdk v2 - configuration loading (eksctl-io#6432)
a177d56 
* Migrate to sdk v2 - configuration loading

* update references to eks instance selector

* fix lint

* add missing unit test expectation

* fix unit tests
idanshoham95 pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Aug 20, 2023
@TiberiuGC
Migrate to sdk v2 - configuration loading (eksctl-io#6432)
b3d464e 
* Migrate to sdk v2 - configuration loading

* update references to eks instance selector

* fix lint

* add missing unit test expectation

* fix unit tests
idanshoham95 pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Aug 20, 2023
@TiberiuGC
Migrate to sdk v2 - configuration loading (eksctl-io#6432)
ce5145a 
* Migrate to sdk v2 - configuration loading

* update references to eks instance selector

* fix lint

* add missing unit test expectation

* fix unit tests
idanshoham95 pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Oct 19, 2023
@TiberiuGC
Migrate to sdk v2 - configuration loading (eksctl-io#6432)
60fee5f 
* Migrate to sdk v2 - configuration loading

* update references to eks instance selector

* fix lint

* add missing unit test expectation

* fix unit tests
idanshoham95 pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Jun 2, 2024
@TiberiuGC
Migrate to sdk v2 - configuration loading (eksctl-io#6432)
42f6892 
* Migrate to sdk v2 - configuration loading

* update references to eks instance selector

* fix lint

* add missing unit test expectation

* fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Himangini Himangini Awaiting requested review from Himangini

1 more reviewer

@cPu1 cPu1 cPu1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/tech-debt Leftover improvements in code, testing and building

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to SDK v2 - credentials Migrate to SDK v2 - configuration loading

3 participants

@TiberiuGC @cPu1 @Himangini