Skip to content

test(ci): add early supported node versions to test matrix #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 6, 2018
Merged

test(ci): add early supported node versions to test matrix #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0045d48
test(ci): add early supported node versions to test matrix
watson Dec 3, 2018
3028324
test(ci): allow newer patch version
watson Dec 5, 2018
ebb125e
test(ci): test on Node 8.1 instead of 8.0 as it's broken
watson Dec 5, 2018
aa0f682
test(ci): allow tests to run on Node 8.0.0->8.5.0
watson Dec 5, 2018
2700272
test(jenkins): add low Node versions to Jenkins matrix as well
watson Dec 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,13 @@ before_script:

node_js:
- '11'
- '11.0'
- '10'
- '10.0'
- '8'
- '8.1'
- '6'
- '6.0'

jobs:
fast_finish: true
Expand Down
4 changes: 4 additions & 0 deletions test/.jenkins_nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
NODEJS_VERSION:
- "11"
- "11.0"
- "10"
- "10.0"
- "8"
- "8.1"
- "6"
- "6.0"
6 changes: 3 additions & 3 deletions test/instrumentation/modules/restify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ test('transaction name', function (t) {

// NOTE: Hostname must be supplied to force IPv4 mode,
// otherwise this will use IPv6, which fails on Travis CI.
server.listen(null, '0.0.0.0', function () {
server.listen(0, '0.0.0.0', function () {
const req = http.get(`${server.url}/hello/world`, res => {
const chunks = []
res.on('data', chunks.push.bind(chunks))
Expand Down Expand Up @@ -95,7 +95,7 @@ test('error reporting', function (t) {

// NOTE: Hostname must be supplied to force IPv4 mode,
// otherwise this will use IPv6, which fails on Travis CI.
server.listen(null, '0.0.0.0', function () {
server.listen(0, '0.0.0.0', function () {
const req = http.get(`${server.url}/hello/world`, res => {
res.resume()
res.on('end', () => {
Expand Down Expand Up @@ -147,7 +147,7 @@ test('error reporting from chained handler', function (t) {

// NOTE: Hostname must be supplied to force IPv4 mode,
// otherwise this will use IPv6, which fails on Travis CI.
server.listen(null, '0.0.0.0', function () {
server.listen(0, '0.0.0.0', function () {
const req = http.get(`${server.url}/hello/world`, res => {
res.resume()
res.on('end', () => {
Expand Down