-
Notifications
You must be signed in to change notification settings - Fork 539
smoketest: Add APM Integration assertions #8600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marclop
merged 3 commits into
elastic:main
from
marclop:f/smoketest-add-apm-package-asset-assertions
Jul 13, 2022
Merged
smoketest: Add APM Integration assertions #8600
marclop
merged 3 commits into
elastic:main
from
marclop:f/smoketest-add-apm-package-asset-assertions
Jul 13, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the remaining assertions for the assets which are created by fleet from the APM Integration (or APM package). It includes: - Component templates and ILM Policies (these two are performed together since they are very closely tied). - Ingest pipelines. It also fixes the smoke tests which were previously broken since the elastic artifacts API only returns the last few previous versions and doesn't provide a comprehensive directory for all the released versions. We now use a regex expression to match the previous minor latest patch version (if 8.3.2 is the latest, then `8.2.latest` will be used). Signed-off-by: Marc Lopez Rubio <[email protected]>
🌐 Coverage report
|
📚 Go benchmark reportDiff with the report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat |
lahsivjar
approved these changes
Jul 13, 2022
Contributor
lahsivjar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…-package-asset-assertions
Signed-off-by: Marc Lopez Rubio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Adds the remaining assertions for the assets which are created by fleet
from the APM Integration (or APM package). It includes:
since they are very closely tied).
It also fixes the smoke tests which were previously broken since the
elastic artifacts API only returns the last few previous versions and
doesn't provide a comprehensive directory for all the released versions.
We now use a regex expression to match the previous minor latest patch
version (if 8.3.2 is the latest, then
8.2.latestwill be used).Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Update package changelog.yml (only if changes toapmpackagehave been made)- [ ] Documentation has been updatedHow to test these changes
make smoketest/all SMOKETEST_VERSIONS=7.17,latestRelated issues
Closes #8303