Skip to content

Conversation

@marclop
Copy link
Contributor

@marclop marclop commented Jul 13, 2022

Motivation/summary

Adds the remaining assertions for the assets which are created by fleet
from the APM Integration (or APM package). It includes:

  • Component templates and ILM Policies (these two are performed together
    since they are very closely tied).
  • Ingest pipelines.

It also fixes the smoke tests which were previously broken since the
elastic artifacts API only returns the last few previous versions and
doesn't provide a comprehensive directory for all the released versions.
We now use a regex expression to match the previous minor latest patch
version (if 8.3.2 is the latest, then 8.2.latest will be used).

Checklist

- [ ] Update CHANGELOG.asciidoc
- [ ] Update package changelog.yml (only if changes to apmpackage have been made)
- [ ] Documentation has been updated

How to test these changes

  1. Export credentials for ESS.
  2. make smoketest/all SMOKETEST_VERSIONS=7.17,latest
  3. Ensure the status code is 0.

Related issues

Closes #8303

Adds the remaining assertions for the assets which are created by fleet
from the APM Integration (or APM package). It includes:

- Component templates and ILM Policies (these two are performed together
  since they are very closely tied).
- Ingest pipelines.

It also fixes the smoke tests which were previously broken since the
elastic artifacts API only returns the last few previous versions and
doesn't provide a comprehensive directory for all the released versions.
We now use a regex expression to match the previous minor latest patch
version (if 8.3.2 is the latest, then `8.2.latest` will be used).

Signed-off-by: Marc Lopez Rubio <[email protected]>
@marclop marclop added enhancement backport-skip Skip notification from the automated backport with mergify v8.4.0 labels Jul 13, 2022
@marclop marclop requested a review from a team July 13, 2022 06:09
@ghost
Copy link

ghost commented Jul 13, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-13T11:22:04.536+0000

  • Duration: 27 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 4109
Skipped 13
Total 4122

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ghost
Copy link

ghost commented Jul 13, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (42/42) 💚
Files 91.96% (183/199) 👍
Classes 93.435% (427/457) 👍
Methods 89.08% (1085/1218) 👎 -0.082
Lines 76.805% (13318/17340) 👎 -0.04
Conditionals 100.0% (0/0) 💚

@ghost
Copy link

ghost commented Jul 13, 2022

📚 Go benchmark report

Diff with the main branch

name                                                                                            old time/op    new time/op     delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/decoder goos:linux goarch:amd64
CompressedRequestReader/gzip_content_encoding-12                                                  16.2µs ±19%     17.3µs ± 1%   +7.18%  (p=0.016 n=5+4)
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessor/events.ndjson-12                                                                  162µs ±25%      112µs ±24%  -30.89%  (p=0.016 n=5+5)
BackendProcessor/metadata-null-values.ndjson-12                                                   5.02µs ± 7%     5.50µs ± 6%   +9.74%  (p=0.016 n=5+5)
BackendProcessor/transactions.ndjson-12                                                            151µs ±17%      118µs ±29%  -21.99%  (p=0.032 n=5+5)
BackendProcessor/unknown-span-type.ndjson-12                                                      50.3µs ± 3%     62.2µs ±15%  +23.59%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/heavy.ndjson-12                       2.11ms ±15%     1.95ms ± 3%   -7.72%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/transactions.ndjson-12                12.9µs ± 1%     13.0µs ± 1%   +1.16%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/otel-bridge.ndjson-12                 13.7µs ± 8%     12.7µs ± 8%   -7.62%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/heavy.ndjson-12                       3.95ms ± 5%     4.29ms ± 7%   +8.68%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/metricsets.ndjson-12                  17.1µs ± 7%     15.4µs ± 6%  -10.23%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/ratelimit.ndjson-12                   40.3µs ± 5%     38.1µs ± 3%   -5.47%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
AggregateTransaction-12                                                                           72.9ns ± 0%     70.4ns ± 1%   -3.42%  (p=0.008 n=5+5)
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
ReadEvents/json_codec/199_events-12                                                               1.31ms ± 0%     1.33ms ± 1%   +1.26%  (p=0.032 n=4+5)
IsTraceSampled/unknown-12                                                                          357ns ± 1%      350ns ± 2%   -1.92%  (p=0.032 n=5+5)

name                                                                                            old alloc/op   new alloc/op    delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessor/events.ndjson-12                                                                 59.4kB ± 2%     61.1kB ± 2%   +2.86%  (p=0.008 n=5+5)
BackendProcessor/otel-bridge.ndjson-12                                                            18.0kB ± 1%     18.4kB ± 2%   +2.38%  (p=0.008 n=5+5)
BackendProcessor/ratelimit.ndjson-12                                                               117kB ± 2%      115kB ± 1%   -1.65%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-json-event.ndjson-12          6.73kB ± 1%     6.80kB ± 1%   +1.06%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/metricsets.ndjson-12                  32.6kB ± 1%     32.4kB ± 1%   -0.69%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
ReadEvents/nop_codec/399_events-12                                                                 898kB ± 0%      899kB ± 0%   +0.17%  (p=0.024 n=5+5)

name                                                                                            old allocs/op  new allocs/op   delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                            old speed      new speed       delta
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessor/events.ndjson-12                                                               46.9MB/s ±31%   67.5MB/s ±21%  +43.93%  (p=0.016 n=5+5)
BackendProcessor/metadata-null-values.ndjson-12                                                  105MB/s ± 7%     96MB/s ± 7%   -8.84%  (p=0.016 n=5+5)
BackendProcessor/transactions.ndjson-12                                                         37.8MB/s ±20%   49.4MB/s ±37%  +30.69%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/heavy.ndjson-12                      190MB/s ±13%    205MB/s ± 3%   +7.85%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/transactions.ndjson-12               438MB/s ± 1%    433MB/s ± 1%   -1.14%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/otel-bridge.ndjson-12                137MB/s ± 8%    148MB/s ± 9%   +8.18%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/heavy.ndjson-12                      101MB/s ± 5%     93MB/s ± 8%   -7.89%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/metricsets.ndjson-12                 149MB/s ± 7%    166MB/s ± 6%  +11.35%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/ratelimit.ndjson-12                  105MB/s ± 5%    111MB/s ± 3%   +5.70%  (p=0.032 n=5+5)

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

Copy link
Contributor

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marclop marclop merged commit 3cd1a63 into elastic:main Jul 13, 2022
@marclop marclop deleted the f/smoketest-add-apm-package-asset-assertions branch July 13, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip notification from the automated backport with mergify enhancement v8.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run automated smoke tests on ESS

2 participants