Skip to content

Conversation

@kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 22, 2025

Proposed commit message

This PR is to change Filebeat azure eventhub input and related modules to use processor v2 as the default.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

For users that are currently still using v1 processor version, they need to add this into their config manually for the new version to work for v1.

How to test this PR locally

Test cases I would like to cover for this change are:

  1. Default (no processor_version)
  2. Set processor_version to v1 for backwards compatibility
  3. Set processor_version to v2

Do we need to test the migration path on Beats?

Related issues

This PR takes care of the Beats side of elastic/integrations#15703. We will need to make the same change in the Integrations.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 22, 2025
@botelastic
Copy link

botelastic bot commented Oct 22, 2025

This pull request doesn't have a Team:<team> label.

@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaiyan-sheng? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

# this field accommodate a description without length limits.
description: This PR is to change Filebeat azure eventhub input to use processor V2 as default instead of V1. Since we've decided to retire processor v1, we plan to set processor v2 as the default option in the next release, and completely remove v1 in the following release.

# REQUIRED for breaking-change, deprecation, known-issue
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmoog What would be the impact and action here for this breaking change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change? If we can continue to support the connection string with the same setting this should not be.

Are we forced to change the config format, making it incompatible with the existing configs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a breaking change! I think we should use deprecation instead. @zmoog wdyt?

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review October 28, 2025 00:22
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner October 28, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants