-
Notifications
You must be signed in to change notification settings - Fork 5k
[beatreceiver] only add default processors if running under agent #47299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beatreceiver] only add default processors if running under agent #47299
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
This is going to break a lot of tests as we expect docuemnts indexed by standalone beats and beatreceivers to be same. And this PR changes the default processors to be available under agent only. Also for Have you tested this change with elastic-agent otel mode? |
090d80b to
5d903cd
Compare
5d903cd to
9d73c1c
Compare
For otel, we specify |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
Before merging this, open a PR in https://github.com/elastic/elastic-agent with the beats dependency updated to this branch and make sure there are no test failures introduced there. |
93eee08 to
a589164
Compare
a85b0d5 to
f337a5a
Compare
…7299) * chore: only add default processors if running unde ragent * fix test * fix test * tab * fix race condition * iterate over keys instead of map * fix test case (cherry picked from commit 78f115e) # Conflicts: # x-pack/filebeat/tests/integration/otel_test.go # x-pack/metricbeat/tests/integration/otel_test.go
…7299) (#47414) * chore: only add default processors if running unde ragent * fix test * fix test * tab * fix race condition * iterate over keys instead of map * fix test case (cherry picked from commit 78f115e) Co-authored-by: Vihas Makwana <[email protected]>
Proposed commit message
We're injecting default processors while running in standalone beatreceivers. This is not the case in standalone beats.
We should inject only if we're running under agent (Fixed via #46539).
Benchmarks shows improvement and are close to normal mode. There is still some difference and I'll work on that as a follow-up.
Checklist
./changelog/fragmentsusing the changelog tool.How to test this PR locally
You can test the build from this PR with benchbuilder and compare the results without the changes of this PR.
Related issues
Results