fix: do not report agent managed otel extensions statuses #10412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoutsovasilis
added
Team:Elastic-Agent-Control-Plane
pkoutsovasilis
force-pushed
the
fix/hide_managed_extensions_status
branch
from
af2827a to
9e7efc7
Compare
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
cmacknz
reviewed
Oct 8, 2025
cmacknz
reviewed
Oct 8, 2025
cmacknz
reviewed
Oct 8, 2025
cmacknz
approved these changes
Oct 8, 2025
💚 Build Succeeded
History
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
* fix: do not report agent managed extensions statuses * fix: clone reported collector status for subprocess to avoid mutations to the internal currentStatus ref * fix: unit-test race conditions * fix: typo and actually assign collectorMetricsPort in unit-test (cherry picked from commit d8f1dae) # Conflicts: # internal/pkg/otel/manager/execution_subprocess.go # internal/pkg/otel/manager/manager.go
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
* fix: do not report agent managed extensions statuses * fix: clone reported collector status for subprocess to avoid mutations to the internal currentStatus ref * fix: unit-test race conditions * fix: typo and actually assign collectorMetricsPort in unit-test (cherry picked from commit d8f1dae) # Conflicts: # internal/pkg/otel/manager/execution_subprocess.go # internal/pkg/otel/manager/manager.go # internal/pkg/otel/manager/manager_test.go
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
* fix: do not report agent managed extensions statuses * fix: clone reported collector status for subprocess to avoid mutations to the internal currentStatus ref * fix: unit-test race conditions * fix: typo and actually assign collectorMetricsPort in unit-test (cherry picked from commit d8f1dae)
8 tasks
pkoutsovasilis
added a commit
that referenced
this pull request
Oct 9, 2025
…10451) * fix: do not report agent managed extensions statuses * fix: clone reported collector status for subprocess to avoid mutations to the internal currentStatus ref * fix: unit-test race conditions * fix: typo and actually assign collectorMetricsPort in unit-test (cherry picked from commit d8f1dae) Co-authored-by: Panos Koutsovasilis <[email protected]>
swiatekm
pushed a commit
that referenced
this pull request
Oct 10, 2025
* fix: do not report agent managed extensions statuses * fix: clone reported collector status for subprocess to avoid mutations to the internal currentStatus ref * fix: unit-test race conditions * fix: typo and actually assign collectorMetricsPort in unit-test
pkoutsovasilis
added a commit
that referenced
this pull request
Oct 14, 2025
* fix: do not report agent managed extensions statuses * fix: clone reported collector status for subprocess to avoid mutations to the internal currentStatus ref * fix: unit-test race conditions * fix: typo and actually assign collectorMetricsPort in unit-test (cherry picked from commit d8f1dae) # Conflicts: # internal/pkg/otel/manager/execution_subprocess.go # internal/pkg/otel/manager/manager.go # Conflicts: # internal/pkg/otel/manager/execution_subprocess.go
pkoutsovasilis
added a commit
that referenced
this pull request
Oct 15, 2025
…ions statuses (#10449) * fix: do not report agent managed otel extensions statuses (#10412) * fix: do not report agent managed extensions statuses * fix: clone reported collector status for subprocess to avoid mutations to the internal currentStatus ref * fix: unit-test race conditions * fix: typo and actually assign collectorMetricsPort in unit-test (cherry picked from commit d8f1dae) # Conflicts: # internal/pkg/otel/manager/execution_subprocess.go # internal/pkg/otel/manager/manager.go # Conflicts: # internal/pkg/otel/manager/execution_subprocess.go * fix: resolve conflicts * fix: wrong rebase * fix: wrong rebase pt2 * Use require.EventuallyWithT --------- Co-authored-by: Panos Koutsovasilis <[email protected]> Co-authored-by: Shaunak Kashyap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR ensures that agent-managed extensions (such as
beatsauth,elastic_diagnostics, and the Agent’s internalhealthcheckv2extension) are not included in the status output, as these are internal implementation details that should not surface to users.Key changes:
handleOtelStatusUpdateto remove known agent-managed extensions (beatsauth/*,elastic_diagnostics, and agent-injectedhealthcheckv2) from the status tree.reportSubprocessCollectorStatus()which safely clones and publishes collector status.cloneCollectorStatus) to prevent mutation races on shared status references between the collector and reporting goroutines.Why is it important?
Previously, all OTel extensions - including agent internal ones - were always visible in
elastic-agent statusoutput.This caused confusion and clutter in the status tree, exposing implementation details irrelevant to users.
By filtering out agent-managed extensions and cloning the status tree before reporting, this change ensures cleaner, more user-focused status output.
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
Since a release with otel runtime enabled by default is not yet published there is no disruptive user impact
How to test this PR locally
Related issues
N/A