Skip to content

[fix] Replace redundant fmt.Errorf with errors.New #10434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[fix] Replace redundant fmt.Errorf with errors.New #10434

wants to merge 10 commits into from

Conversation

@hayotbisonai
Copy link
Contributor

@hayotbisonai hayotbisonai commented Oct 9, 2025

What does this PR do?

  • Replaced constant fmt.Errorf("msg") → errors.New("msg")
  • No behavioral changes

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@hayotbisonai hayotbisonai requested a review from a team as a code owner October 9, 2025 05:26
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025

This pull request does not have a backport label. Could you fix it @hayotbisonai? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 9, 2025
@blakerouse blakerouse added the backport-active-all Automated backport with mergify to all the active branches label Oct 9, 2025
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 9, 2025

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

blakerouse
blakerouse requested changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a file importing both "errors" and the ".../errors" package that the Elastic Agent has. That needs to be fixed.

@hayotbisonai
Copy link
Contributor Author

hayotbisonai commented Oct 10, 2025

You have a file importing both "errors" and the ".../errors" package that the Elastic Agent has. That needs to be fixed.

@blakerouse Thanks for catching it! I made quick fix here 234e5ff

@ebeahan
Copy link
Member

ebeahan commented Oct 24, 2025

Buildkite test this

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 24, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @hayotbisonai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@blakerouse blakerouse Awaiting requested review from blakerouse

Requested changes must be addressed to merge this pull request.

Assignees

@hayotbisonai hayotbisonai

Labels

backport-active-all Automated backport with mergify to all the active branches Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hayotbisonai @elasticmachine @ebeahan @blakerouse @pierrehilbert