Skip to content

Conversation

@hayotbisonai
Copy link
Contributor

@hayotbisonai hayotbisonai commented Oct 10, 2025

What does this PR do?

  • Replace deprecated SetupMetrics with SetupMetricsOptions
  • Added new helper func generateEphemeralID that generates id for setting up metrics

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@hayotbisonai hayotbisonai requested a review from a team as a code owner October 10, 2025 03:17
@hayotbisonai hayotbisonai changed the title fix: replace deprecated function [fix] Replace deprecated SetupMetrics with SetupMetricsOptions Oct 10, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2025

This pull request does not have a backport label. Could you fix it @hayotbisonai? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 10, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix/replace-deprecated-setmetrics upstream/fix/replace-deprecated-setmetrics
git merge upstream/main
git push upstream fix/replace-deprecated-setmetrics

pierrehilbert and others added 4 commits October 10, 2025 22:17
* chore: remove otel diagnostics from manager

* test

* more testing and refactor

* fix tests

* refactor
* Fix troubleshooting message URL for versions after 9.x

* Add changelog fragment

* Change troubleshoot message to a const variable

* Fix build issue created by the merge

* Fix linter issue

* Revert linter fix and add nolint comment
Name: agentName,
Version: version.GetDefaultVersion(),
Logger: logger,
EphemeralID: ephemeralID,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebeahan
Copy link
Member

ebeahan commented Oct 24, 2025

Please also add a changelog entry.

@pchila pchila removed the request for review from pkoutsovasilis November 11, 2025 17:28
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix/replace-deprecated-setmetrics upstream/fix/replace-deprecated-setmetrics
git merge upstream/main
git push upstream fix/replace-deprecated-setmetrics

@ebeahan
Copy link
Member

ebeahan commented Nov 19, 2025

@hayotbisonai are you planning to continue with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants