Skip to content

Conversation

pchila
Copy link
Member

@pchila pchila commented Jul 30, 2025

What does this PR do?

Fix minimum version check to assert rollback reason when an elastic-agent upgrade is automatically rolled back.
PR #8407 didn't make it into 9.1 before the release branch was detached, so with the new version 9.1.0 being released, test TestStandaloneUpgradeRollback wrongly expected to find the rollback reason from a 9.1.0 elastic-agent status output.

Why is it important?

To have correct assertions for TestStandaloneUpgradeRollback integration tests.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

Copy link
Contributor

mergify bot commented Jul 30, 2025

This pull request does not have a backport label. Could you fix it @pchila? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pchila
Copy link
Member Author

pchila commented Jul 30, 2025

CI run on top of the version bump PR #9172: https://buildkite.com/elastic/elastic-agent/builds/24573 (to verify that the issue is fixed).

Will rebase onto main and mark it ready for review.

@pchila pchila force-pushed the fix-version-check-in-rollback-tests branch from 2d3de92 to ffdbefd Compare July 30, 2025 09:59
@pchila pchila marked this pull request as ready for review July 30, 2025 10:00
@pchila pchila requested a review from a team as a code owner July 30, 2025 10:00
Copy link

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pchila

@pchila pchila requested a review from pkoutsovasilis July 30, 2025 12:10
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing that @pchila

@pchila pchila merged commit c7b9637 into elastic:main Jul 30, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants