Skip to content

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Aug 6, 2025

What does this PR do?

This PR restricts the versions used as start versions in TestUpgradeIntegrationsServer to those actually available in the ECH region where the integrations server is being run.

Why is it important?

The test should not attempt to use a start version that doesn't actually exist in the ECH region where the integrations server deployment will be created.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

None; this PR modifies an integration test.

Related issues

Follow up to #9207 (comment)

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

Copy link
Contributor

mergify bot commented Aug 6, 2025

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@ycombinator
Copy link
Contributor Author

ycombinator commented Aug 7, 2025

CI is green while running the TestUpgradeIntegrationsServer test but without including the version change in #9172. I will now include that change in this PR — by rebasing on main since #9172 has now been merged — as a test to see if the 8.19.0 version gets excluded as expected and CI still remains green.

Copy link
Contributor

mergify bot commented Aug 7, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b it-fips-upgrade-integrations-server-versions upstream/it-fips-upgrade-integrations-server-versions
git merge upstream/main
git push upstream it-fips-upgrade-integrations-server-versions

@ycombinator ycombinator force-pushed the it-fips-upgrade-integrations-server-versions branch from 3820a0b to 3a42695 Compare August 7, 2025 20:06
Copy link

@ycombinator ycombinator marked this pull request as ready for review August 7, 2025 21:50
@ycombinator ycombinator requested a review from a team as a code owner August 7, 2025 21:50
@ycombinator ycombinator added backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Aug 7, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @ycombinator

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that the issue we faced on the PR on main is no longer here and the code checks out, thus, LGTM

@ycombinator ycombinator merged commit febd3fc into elastic:main Aug 7, 2025
22 checks passed
@ycombinator ycombinator deleted the it-fips-upgrade-integrations-server-versions branch August 7, 2025 22:20
mergify bot pushed a commit that referenced this pull request Aug 7, 2025
…eIntegrationsServer` (#9266)

* Only consider versions available in ECH region for FIPS integrations server upgrade test

* Separate out ECH filtering

* Pass provisioner to filter function

(cherry picked from commit febd3fc)
mergify bot pushed a commit that referenced this pull request Aug 7, 2025
…eIntegrationsServer` (#9266)

* Only consider versions available in ECH region for FIPS integrations server upgrade test

* Separate out ECH filtering

* Pass provisioner to filter function

(cherry picked from commit febd3fc)
ycombinator added a commit that referenced this pull request Aug 8, 2025
…eIntegrationsServer` (#9266) (#9289)

* Only consider versions available in ECH region for FIPS integrations server upgrade test

* Separate out ECH filtering

* Pass provisioner to filter function

(cherry picked from commit febd3fc)

Co-authored-by: Shaunak Kashyap <[email protected]>
ycombinator added a commit that referenced this pull request Aug 8, 2025
…eIntegrationsServer` (#9266) (#9288)

* Only consider versions available in ECH region for FIPS integrations server upgrade test

* Separate out ECH filtering

* Pass provisioner to filter function

(cherry picked from commit febd3fc)

Co-authored-by: Shaunak Kashyap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Testing:run:TestUpgradeIntegrationsServer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants