-
Notifications
You must be signed in to change notification settings - Fork 197
[FIPS] Only consider versions available in ECH region for TestUpgradeIntegrationsServer
#9266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIPS] Only consider versions available in ECH region for TestUpgradeIntegrationsServer
#9266
Conversation
This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
|
CI is green while running the |
This pull request is now in conflicts. Could you fix it? 🙏
|
3820a0b
to
3a42695
Compare
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
💚 Build Succeeded
History
cc @ycombinator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that the issue we faced on the PR on main is no longer here and the code checks out, thus, LGTM
…eIntegrationsServer` (#9266) (#9289) * Only consider versions available in ECH region for FIPS integrations server upgrade test * Separate out ECH filtering * Pass provisioner to filter function (cherry picked from commit febd3fc) Co-authored-by: Shaunak Kashyap <[email protected]>
…eIntegrationsServer` (#9266) (#9288) * Only consider versions available in ECH region for FIPS integrations server upgrade test * Separate out ECH filtering * Pass provisioner to filter function (cherry picked from commit febd3fc) Co-authored-by: Shaunak Kashyap <[email protected]>
What does this PR do?
This PR restricts the versions used as start versions in
TestUpgradeIntegrationsServer
to those actually available in the ECH region where the integrations server is being run.Why is it important?
The test should not attempt to use a start version that doesn't actually exist in the ECH region where the integrations server deployment will be created.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry in./changelog/fragments
using the changelog toolI have added an integration test or an E2E testDisruptive User Impact
None; this PR modifies an integration test.
Related issues
Follow up to #9207 (comment)
Questions to ask yourself