Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Sep 2, 2025

What does this PR do?

Enable some automated dependency management for EDOT SDK docker images in the elastic-agent repository using updatecli. The automation tracks latest releases from EDOT SDK repositories and creates pull requests to update image versions in Helm chart configurations.

Why is it important?

Previously, EDOT SDK image versions in elastic-agent had to be updated manually, as shown in #7327. This manual process was time-consuming and could lead to outdated dependencies.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

$ GITHUB_TOKEN=$(gh auth token) \
   GITHUB_ACTOR=v1v \
   updatecli diff --config .ci/updatecli/updatecli-bump-edot.yml --values .ci/updatecli/values.d/scm.yml

and

--- a/.ci/updatecli/values.d/scm.yml
+++ b/.ci/updatecli/values.d/scm.yml
@@ -1,8 +1,8 @@
 scm:
   enabled: true
-  owner: elastic
+  owner: v1v
   repository: elastic-agent
-  branch: main
+  branch: test/updatecli-branch
   commitusingapi: true
   # begin updatecli-compose policy values
   user: 'github-actions[bot]'

produced

SUMMARY:

⚠ Bump golang-version to latest version:
	Source:
		✔ [elastic-otel-dotnet] Get latest Elastic OTEL .NET release
		✔ [elastic-otel-java] Get latest Elastic OTEL Java release
		✔ [elastic-otel-node] Get latest Elastic OTEL Node.js release
		✔ [elastic-otel-python] Get latest Elastic OTEL Python release
		✔ [otel-go-instrumentation] Get latest OpenTelemetry Go Instrumentation release
	Target:
		⚠ [update-dotnet-managed-otlp] Update Elastic OTEL .NET image in values.yaml
		⚠ [update-go-main] Update OpenTelemetry Go Instrumentation image in values.yaml
		⚠ [update-java-managed-otlp] Update Elastic OTEL Java image in values.yaml
		⚠ [update-nodejs-managed-otlp] Update Elastic OTEL Node.js image in values.yaml
		⚠ [update-python-managed-otlp] Update Elastic OTEL Python image in managed_otlp/values.yaml


Run Summary
===========
Pipeline(s) run:
  * Changed:	1
  * Failed:	0
  * Skipped:	0
  * Succeeded:	0
  * Total:	1

then if I applied the changes

$ GITHUB_TOKEN=$(gh auth token) \
   GITHUB_ACTOR=v1v \
   updatecli apply --config .ci/updatecli/updatecli-bump-edot.yml --values .ci/updatecli/values.d/scm.yml

SUMMARY:

⚠ Bump golang-version to latest version:
	Source:
		✔ [elastic-otel-dotnet] Get latest Elastic OTEL .NET release
		✔ [elastic-otel-java] Get latest Elastic OTEL Java release
		✔ [elastic-otel-node] Get latest Elastic OTEL Node.js release
		✔ [elastic-otel-python] Get latest Elastic OTEL Python release
		✔ [otel-go-instrumentation] Get latest OpenTelemetry Go Instrumentation release
	Target:
		⚠ [update-dotnet-managed-otlp] Update Elastic OTEL .NET image in values.yaml
		⚠ [update-go-main] Update OpenTelemetry Go Instrumentation image in values.yaml
		⚠ [update-java-managed-otlp] Update Elastic OTEL Java image in values.yaml
		⚠ [update-nodejs-managed-otlp] Update Elastic OTEL Node.js image in values.yaml
		⚠ [update-python-managed-otlp] Update Elastic OTEL Python image in managed_otlp/values.yaml


Run Summary
===========
Pipeline(s) run:
  * Changed:	1
  * Failed:	0
  * Skipped:	0
  * Succeeded:	0
  * Total:	1

One action to follow up:
  * https://github.com/v1v/elastic-agent/pull/11

Caveats

It removes the inline comments:

image

Shall we remove them? Or move them one line above so they are not removed by the updatecli automation?

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@v1v v1v self-assigned this Sep 2, 2025
@v1v v1v requested review from pkoutsovasilis and trentm September 2, 2025 14:41
@v1v v1v marked this pull request as ready for review September 2, 2025 14:41
@v1v v1v requested a review from a team as a code owner September 2, 2025 14:41
oakrizan
oakrizan previously approved these changes Sep 4, 2025
Copy link
Contributor

@oakrizan oakrizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@v1v v1v requested a review from a team September 4, 2025 08:28
fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n previously approved these changes Sep 4, 2025
Copy link
Contributor

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Regarding the caveat, I would like to keep those comments putting them just in the line above

@v1v v1v dismissed stale reviews from fr4nc1sc0-r4m0n and oakrizan via 6b4ae3e September 4, 2025 10:55
@v1v v1v requested a review from a team as a code owner September 4, 2025 10:55
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in kube-stack files look good to me.

@elasticmachine
Copy link
Collaborator

⏳ Build in-progress, with failures

Failed CI Steps

cc @v1v

@v1v
Copy link
Member Author

v1v commented Sep 4, 2025

Regarding the caveat, I would like to keep those comments putting them just in the line above

I changed it at 6b4ae3e (#9686) and tested the changes locally, so v1v#12 works nicely now

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@v1v v1v requested a review from fr4nc1sc0-r4m0n September 5, 2025 08:40
@v1v v1v enabled auto-merge (squash) September 5, 2025 08:40
@v1v v1v added backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches and removed backport-skip labels Sep 5, 2025
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed only the github action and it makes sense, however I don't know the specifics of the EDOT SDK versioning

Copy link
Contributor

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1v v1v merged commit 3549dea into elastic:main Sep 5, 2025
28 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

@Mergifyio backport 8.18 8.19 9.0 9.1

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2025

mergify bot pushed a commit that referenced this pull request Sep 5, 2025
mergify bot pushed a commit that referenced this pull request Sep 5, 2025
mergify bot pushed a commit that referenced this pull request Sep 5, 2025
mergify bot pushed a commit that referenced this pull request Sep 5, 2025
v1v pushed a commit that referenced this pull request Sep 5, 2025
v1v pushed a commit that referenced this pull request Sep 5, 2025
v1v pushed a commit that referenced this pull request Sep 8, 2025
v1v pushed a commit that referenced this pull request Sep 9, 2025
intxgo pushed a commit to intxgo/elastic-agent that referenced this pull request Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants