-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Unmute CCSDuelIT_testTerminateAfter test #132648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmute CCSDuelIT_testTerminateAfter test #132648
Conversation
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
Could you help me understand how its presence causes the test to fail and get muted? |
|
@pawankartik-elastic Please address the assertion error mentioned in the reported ticket. The failure occurs when terminated_early does not match. |
|
We may want to backport it since the original issue is on 8.19 |
|
Thank you both! |
💚 Backport successful
|
|
@drempapis 8.19 too? |
|
@smalyshev This issue was initially reported but not muted in the branch version 8.19. |
I removed the "terminated_early" from the responseToMap(...); This is a best-effort, transport metadata, and removing it only affects the local comparison map, not the server response, and none of the tests assert on that flag. The intent of all the tests in the class is preserved. If we ever need to test terminated_early explicitly, that should be a separate, targeted test, not this CCS duel.
Closes 126085