Skip to content

Conversation

@drempapis
Copy link
Contributor

@drempapis drempapis commented Aug 11, 2025

I removed the "terminated_early" from the responseToMap(...); This is a best-effort, transport metadata, and removing it only affects the local comparison map, not the server response, and none of the tests assert on that flag. The intent of all the tests in the class is preserved. If we ever need to test terminated_early explicitly, that should be a separate, targeted test, not this CCS duel.

Closes 126085

@drempapis drempapis added >test Issues or PRs that are addressing/adding tests Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations labels Aug 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@pawankartik-elastic
Copy link
Contributor

Could you help me understand how its presence causes the test to fail and get muted?

@drempapis
Copy link
Contributor Author

drempapis commented Aug 11, 2025

@pawankartik-elastic Please address the assertion error mentioned in the reported ticket. The failure occurs when terminated_early does not match.

java.lang.AssertionError: Comparing async_search minimizeRoundTrip vs. fanOut. Didn't match expected value. /terminated_early: the elements don't match: [true] != [false].
Full diff                      _clusters: 
                         details: 
                 my_remote_cluster: 
                             _shards: 
                                failed: same [0]
                               skipped: same [0]
                            successful: same [5]
                                 total: same [5]
                             indices: same [ccs_duel_index]
                              status: same [successful]
                           timed_out: same [false]
                                took: same [-1]
                          failed: same [0]
                         partial: same [0]
                         running: same [0]
                         skipped: same [0]
                      successful: same [1]
                           total: same [1]
     
[truncated]

@smalyshev
Copy link
Contributor

We may want to backport it since the original issue is on 8.19

@drempapis
Copy link
Contributor Author

Thank you both!

@drempapis drempapis added auto-backport Automatically create backport pull requests when merged v9.1.0 labels Aug 11, 2025
@drempapis drempapis merged commit dcff4d3 into elastic:main Aug 11, 2025
33 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.1

drempapis added a commit to drempapis/elasticsearch that referenced this pull request Aug 11, 2025
@smalyshev
Copy link
Contributor

@drempapis 8.19 too?

@drempapis
Copy link
Contributor Author

@smalyshev This issue was initially reported but not muted in the branch version 8.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] CCSDuelIT testTerminateAfter failing

4 participants