Fix testFollowerCheckerDetectsUnresponsiveNodeAfterMasterReelection #84200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test would fail if we introduce the network partition while the master is still publishing a cluster state update and hasn't received the ack from the victim node. In this case the default publish timeout means that the master will wait for 30s before completing the stalled publication and moving on to the `node-left` one, but `ensureStableCluster` also times out after 30s which leaves not much time for the master to remove the victim node. This commit reduces the publish timeout to 10s so that the master recovers well before `ensureStableCluster` times out. Closes elastic#84172
DaveCTurner
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
Feb 22, 2022
DaveCTurner
deleted the
2022-02-21-fix-testFollowerCheckerDetectsUnresponsiveNodeAfterMasterReelection
branch
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
that referenced
this pull request
Feb 22, 2022
…84200) This test would fail if we introduce the network partition while the master is still publishing a cluster state update and hasn't received the ack from the victim node. In this case the default publish timeout means that the master will wait for 30s before completing the stalled publication and moving on to the `node-left` one, but `ensureStableCluster` also times out after 30s which leaves not much time for the master to remove the victim node. This commit reduces the publish timeout to 10s so that the master recovers well before `ensureStableCluster` times out. Closes #84172
DaveCTurner
added a commit
that referenced
this pull request
Feb 22, 2022
…84200) This test would fail if we introduce the network partition while the master is still publishing a cluster state update and hasn't received the ack from the victim node. In this case the default publish timeout means that the master will wait for 30s before completing the stalled publication and moving on to the `node-left` one, but `ensureStableCluster` also times out after 30s which leaves not much time for the master to remove the victim node. This commit reduces the publish timeout to 10s so that the master recovers well before `ensureStableCluster` times out. Closes #84172
DaveCTurner
added a commit
that referenced
this pull request
Feb 22, 2022
…84200) This test would fail if we introduce the network partition while the master is still publishing a cluster state update and hasn't received the ack from the victim node. In this case the default publish timeout means that the master will wait for 30s before completing the stalled publication and moving on to the `node-left` one, but `ensureStableCluster` also times out after 30s which leaves not much time for the master to remove the victim node. This commit reduces the publish timeout to 10s so that the master recovers well before `ensureStableCluster` times out. Closes #84172
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 23, 2022
…lastic#84200) This test would fail if we introduce the network partition while the master is still publishing a cluster state update and hasn't received the ack from the victim node. In this case the default publish timeout means that the master will wait for 30s before completing the stalled publication and moving on to the `node-left` one, but `ensureStableCluster` also times out after 30s which leaves not much time for the master to remove the victim node. This commit reduces the publish timeout to 10s so that the master recovers well before `ensureStableCluster` times out. Closes elastic#84172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test would fail if we introduce the network partition while the
master is still publishing a cluster state update and hasn't received
the ack from the victim node. In this case the default publish timeout
means that the master will wait for 30s before completing the stalled
publication and moving on to the
node-leftone, butensureStableClusteralso times out after 30s which leaves not muchtime for the master to remove the victim node.
This commit reduces the publish timeout to 10s so that the master
recovers well before
ensureStableClustertimes out.Closes #84172