Adding quotes in pqcheck.bat to support spaces in path #16205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 Build Succeeded
|
|
@logstashmachine backport 8.14 |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
(cherry picked from commit bc0b955)
5 tasks
jsvd
pushed a commit
that referenced
this pull request
Jul 4, 2024
(cherry picked from commit bc0b955) Co-authored-by: Alex S <[email protected]>
andsel
pushed a commit
to andsel/logstash
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
What does this PR do?
There was a tiny oversight in the Windows batch file, resulting in the
pqcheck.batfile not working when Logstash is installed in a path with a space.Why is it important/What is the impact to the user?
This PR fixes an issue that was preventing the
pqcheck.batfile from running if it's in a path with a space, for example:C:\Program Files\logstash-8.8.2Checklist