Backport PR #17032 to 8.18: Don't honor VERSION_QUALIFIER if set but empty #17069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907. --------- Co-authored-by: Andrea Selva <[email protected]> (cherry picked from commit c7204fd)
|
💚 Build Succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #17032 to 8.18 branch, original message:
Release notes
[rn:skip]
What does this PR do?
PR#17006 revealed that the
VERSION_QUALIFIERenv var gets honored in various scripts when present but empty.This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable.
This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907.
Why is it important/What is the impact to the user?
Makes the behavior consistent with DRA guidelines and allows to re-revert PR#17006
How to test this PR locally
Best tested with Buildkite. Test builds using this PR, DRA_BRABCH=main and
VERSION_QUALIFIER="":snapshot: https://buildkite.com/elastic/logstash-dra-snapshot-pipeline/builds/2169#_
staging (dry_run=true, so no publishing): https://buildkite.com/elastic/logstash-dra-staging-pipeline/builds/194
Also tested staging with dry_run=true and VERSION_QUALIFIER="alpha1" (this isn't getting published): https://buildkite.com/elastic/logstash-dra-staging-pipeline/builds/196