Skip to content

Pin faraday-v2. #17312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Pin faraday-v2. #17312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ gem "ruby-maven-libs", "~> 3", ">= 3.9.6.1"
gem "logstash-output-elasticsearch", ">= 11.14.0"
gem "polyglot", require: false
gem "treetop", require: false
gem "faraday", "~> 2", :require => false # due elastic-transport depending faraday '~> 2'
Copy link
Member

@donoghuc donoghuc Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite following... Is elastic-transport not specifying a dependency correctly? Not sure why bundler would not be providing >= 2 if its a dependency?

Copy link
Member

@donoghuc donoghuc Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like if elastic-transport requires faraday ~> 2 that gem should be specifying that.

Copy link
Contributor Author

@mashhurs mashhurs Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After 🚶‍♂️, I was questioning myself why faraday-v1 was consumed in 9.0?! I found reason that I didn't remove faraday (~> 1) here 🤦 .
So, this change is unnecessary now. I have checked in 8.x branches as well that all consuming faraday-v2.
I will close this.

gem "minitar", "~> 1", :group => :build
gem "childprocess", "~> 4", :group => :build
gem "fpm", "~> 1", ">= 1.14.1", :group => :build # compound due to bugfix https://github.com/jordansissel/fpm/pull/1856
Expand Down