Skip to content

Conversation

@eedugon
Copy link
Contributor

@eedugon eedugon commented May 8, 2025

Release notes updated.
@karenzone : In this case I've added the message in the release notes asciidoc file for both 8.18.1 and 8.17.6, as the file include both.

Let me know if this is correct. Thanks!

@eedugon eedugon requested a review from karenzone May 8, 2025 11:26
@karenzone
Copy link
Contributor

@karenzone : In this case I've added the message in the release notes asciidoc file for both 8.18.1 and 8.17.6, as the file include both.
Let me know if this is correct. Thanks!

@eedugon You nailed it! Thanks for the making the additions.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karenzone karenzone merged commit 7c8391a into 8.18 May 8, 2025
6 checks passed
@karenzone
Copy link
Contributor

25678

karenzone pushed a commit to karenzone/logstash that referenced this pull request May 9, 2025
PR elastic#17219 introduced configurable split quantities for IT tests, which
resulted in broken JDK matrix pipelines (e.g. as seen via the elastic
internal link:
https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/444

reporting the following error

```
  File "/buildkite/builds/bk-agent-prod-k8s-1743469287077752648/elastic/logstash-linux-jdk-matrix-pipeline/.buildkite/scripts/jdk-matrix-tests/generate-steps.py", line 263
    def integration_tests(self, part: int, parts: int) -> JobRetValues:
    ^^^
SyntaxError: invalid syntax
There was a problem rendering the pipeline steps.
Exiting now.
```
)

This commit fixes the above problem, which was already fixed in elastic#17642, using a more
idiomatic way.

Co-authored-by: Andrea Selva <[email protected]>
andsel pushed a commit to andsel/logstash that referenced this pull request May 21, 2025
…lastic#17514)

PR elastic#17219 introduced configurable split quantities for IT tests, which
resulted in broken JDK matrix pipelines (e.g. as seen via the elastic
internal link:
https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/444

reporting the following error

```
  File "/buildkite/builds/bk-agent-prod-k8s-1743469287077752648/elastic/logstash-linux-jdk-matrix-pipeline/.buildkite/scripts/jdk-matrix-tests/generate-steps.py", line 263
    def integration_tests(self, part: int, parts: int) -> JobRetValues:
    ^^^
SyntaxError: invalid syntax
There was a problem rendering the pipeline steps.
Exiting now.
```
)

This commit fixes the above problem, which was already fixed in elastic#17642, using a more
idiomatic way.

Co-authored-by: Andrea Selva <[email protected]>
(cherry picked from commit b9469e0)

Co-authored-by: Dimitrios Liappis <[email protected]>
andsel pushed a commit to andsel/logstash that referenced this pull request May 26, 2025
…lastic#17512)

PR elastic#17219 introduced configurable split quantities for IT tests, which
resulted in broken JDK matrix pipelines (e.g. as seen via the elastic
internal link:
https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/444

reporting the following error

```
  File "/buildkite/builds/bk-agent-prod-k8s-1743469287077752648/elastic/logstash-linux-jdk-matrix-pipeline/.buildkite/scripts/jdk-matrix-tests/generate-steps.py", line 263
    def integration_tests(self, part: int, parts: int) -> JobRetValues:
    ^^^
SyntaxError: invalid syntax
There was a problem rendering the pipeline steps.
Exiting now.
```
)

This commit fixes the above problem, which was already fixed in elastic#17642, using a more
idiomatic way.

Co-authored-by: Andrea Selva <[email protected]>
(cherry picked from commit b9469e0)

Co-authored-by: Dimitrios Liappis <[email protected]>
edmocosta pushed a commit to edmocosta/logstash that referenced this pull request Jun 18, 2025
…lastic#17513)

PR elastic#17219 introduced configurable split quantities for IT tests, which
resulted in broken JDK matrix pipelines (e.g. as seen via the elastic
internal link:
https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/444

reporting the following error

```
  File "/buildkite/builds/bk-agent-prod-k8s-1743469287077752648/elastic/logstash-linux-jdk-matrix-pipeline/.buildkite/scripts/jdk-matrix-tests/generate-steps.py", line 263
    def integration_tests(self, part: int, parts: int) -> JobRetValues:
    ^^^
SyntaxError: invalid syntax
There was a problem rendering the pipeline steps.
Exiting now.
```
)

This commit fixes the above problem, which was already fixed in elastic#17642, using a more
idiomatic way.

Co-authored-by: Andrea Selva <[email protected]>
(cherry picked from commit b9469e0)

Co-authored-by: Dimitrios Liappis <[email protected]>
jsvd pushed a commit to jsvd/logstash that referenced this pull request Jun 26, 2025
…lastic#17510)

PR elastic#17219 introduced configurable split quantities for IT tests, which
resulted in broken JDK matrix pipelines (e.g. as seen via the elastic
internal link:
https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/444

reporting the following error

```
  File "/buildkite/builds/bk-agent-prod-k8s-1743469287077752648/elastic/logstash-linux-jdk-matrix-pipeline/.buildkite/scripts/jdk-matrix-tests/generate-steps.py", line 263
    def integration_tests(self, part: int, parts: int) -> JobRetValues:
    ^^^
SyntaxError: invalid syntax
There was a problem rendering the pipeline steps.
Exiting now.
```
)

This commit fixes the above problem, which was already fixed in elastic#17642, using a more
idiomatic way.

Co-authored-by: Andrea Selva <[email protected]>
(cherry picked from commit b9469e0)

Co-authored-by: Dimitrios Liappis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants