fixing thin and zero width white space characters in docs #18019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @georgewallace? 🙏
|
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
karenzone
approved these changes
Aug 22, 2025
georgewallace
added
backport-9.0
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2025
(cherry picked from commit 5f7a6cd)
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2025
(cherry picked from commit 5f7a6cd)
donoghuc
added a commit
to donoghuc/logstash
that referenced
this pull request
Sep 3, 2025
Following up on elastic#18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from elastic#18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer.
donoghuc
added a commit
that referenced
this pull request
Sep 4, 2025
* Ensure any file object in a tar archive has an mtime Following up on #18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from #18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 4, 2025
* Ensure any file object in a tar archive has an mtime Following up on #18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from #18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 4, 2025
* Ensure any file object in a tar archive has an mtime Following up on #18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from #18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 4, 2025
* Ensure any file object in a tar archive has an mtime Following up on #18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from #18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 4, 2025
* Ensure any file object in a tar archive has an mtime Following up on #18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from #18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 4, 2025
* Ensure any file object in a tar archive has an mtime Following up on #18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from #18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 4, 2025
…artifacts (#18108) * Preserve mtime explicitly when creating tar artifacts (#18091) * Preserve mtime explicitly when creating tar artifacts When building tar archives, explicitly set mtime. This avoids losing that information in the minitar `Writer.add_file_simple` method https://github.com/halostatue/minitar/blob/a531136b17b9efdddf0a0f39537845b454c2371e/lib/minitar/writer.rb#L139 * Better default for mtime If for some reason we cant get a time from a File object (very unlikely) a better default is Time.now rather than 0. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]> (cherry picked from commit d9b95bf) # Conflicts: # rakelib/artifacts.rake * Ensure any file object in a tar archive has an mtime (#18113) * Ensure any file object in a tar archive has an mtime Following up on #18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from #18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]> * fix merge conflicts --------- Co-authored-by: Cas Donoghue <[email protected]> Co-authored-by: João Duarte <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 4, 2025
…artifacts (#18109) * Preserve mtime explicitly when creating tar artifacts (#18091) * Preserve mtime explicitly when creating tar artifacts When building tar archives, explicitly set mtime. This avoids losing that information in the minitar `Writer.add_file_simple` method https://github.com/halostatue/minitar/blob/a531136b17b9efdddf0a0f39537845b454c2371e/lib/minitar/writer.rb#L139 * Better default for mtime If for some reason we cant get a time from a File object (very unlikely) a better default is Time.now rather than 0. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]> (cherry picked from commit d9b95bf) # Conflicts: # rakelib/artifacts.rake * Ensure any file object in a tar archive has an mtime (#18113) * Ensure any file object in a tar archive has an mtime Following up on #18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from #18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]> * fix merge conflicts --------- Co-authored-by: Cas Donoghue <[email protected]> Co-authored-by: João Duarte <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 4, 2025
…rtifacts (#18111) * Preserve mtime explicitly when creating tar artifacts (#18091) * Preserve mtime explicitly when creating tar artifacts When building tar archives, explicitly set mtime. This avoids losing that information in the minitar `Writer.add_file_simple` method https://github.com/halostatue/minitar/blob/a531136b17b9efdddf0a0f39537845b454c2371e/lib/minitar/writer.rb#L139 * Better default for mtime If for some reason we cant get a time from a File object (very unlikely) a better default is Time.now rather than 0. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]> (cherry picked from commit d9b95bf) # Conflicts: # rakelib/artifacts.rake * Ensure any file object in a tar archive has an mtime (#18113) * Ensure any file object in a tar archive has an mtime Following up on #18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from #18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]> * fix merge conflicts --------- Co-authored-by: Cas Donoghue <[email protected]> Co-authored-by: João Duarte <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 4, 2025
…rtifacts (#18112) * Preserve mtime explicitly when creating tar artifacts (#18091) * Preserve mtime explicitly when creating tar artifacts When building tar archives, explicitly set mtime. This avoids losing that information in the minitar `Writer.add_file_simple` method https://github.com/halostatue/minitar/blob/a531136b17b9efdddf0a0f39537845b454c2371e/lib/minitar/writer.rb#L139 * Better default for mtime If for some reason we cant get a time from a File object (very unlikely) a better default is Time.now rather than 0. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]> (cherry picked from commit d9b95bf) # Conflicts: # rakelib/artifacts.rake * Ensure any file object in a tar archive has an mtime (#18113) * Ensure any file object in a tar archive has an mtime Following up on #18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from #18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]> * fix merge conflicts --------- Co-authored-by: Cas Donoghue <[email protected]> Co-authored-by: João Duarte <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 4, 2025
…artifacts (#18110) * Preserve mtime explicitly when creating tar artifacts (#18091) * Preserve mtime explicitly when creating tar artifacts When building tar archives, explicitly set mtime. This avoids losing that information in the minitar `Writer.add_file_simple` method https://github.com/halostatue/minitar/blob/a531136b17b9efdddf0a0f39537845b454c2371e/lib/minitar/writer.rb#L139 * Better default for mtime If for some reason we cant get a time from a File object (very unlikely) a better default is Time.now rather than 0. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]> (cherry picked from commit d9b95bf) * Ensure any file object in a tar archive has an mtime (#18113) * Ensure any file object in a tar archive has an mtime Following up on #18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from #18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer. * Update rakelib/artifacts.rake Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: João Duarte <[email protected]> --------- Co-authored-by: Cas Donoghue <[email protected]> Co-authored-by: João Duarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Zero width and thin space white space in the docs that keep showing github errors when creating PRs