Skip to content

[8.19] (backport #18091) Preserve mtime explicitly when creating tar artifacts #18110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

[8.19] (backport #18091) Preserve mtime explicitly when creating tar artifacts #18110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f6b404
Preserve mtime explicitly when creating tar artifacts (#18091)
donoghuc Sep 3, 2025
6918320
Ensure any file object in a tar archive has an mtime (#18113)
donoghuc Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions rakelib/artifacts.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,12 +653,14 @@ namespace "artifact" do

def write_to_tar(tar, path, path_in_tar)
stat = File.lstat(path)
# in the off-chance that mtime returns nil we don't want nil to be interpreted as epoch, so fall back to Time.now
mtime = (stat.mtime || Time.now).to_i
if stat.directory?
tar.mkdir(path_in_tar, :mode => stat.mode)
tar.mkdir(path_in_tar, :mode => stat.mode, :mtime => mtime)
elsif stat.symlink?
tar.symlink(path_in_tar, File.readlink(path), :mode => stat.mode)
tar.symlink(path_in_tar, File.readlink(path), :mode => stat.mode, :mtime => mtime)
else
tar.add_file_simple(path_in_tar, :mode => stat.mode, :size => stat.size) do |io|
tar.add_file_simple(path_in_tar, :mode => stat.mode, :size => stat.size, :mtime => mtime) do |io|
File.open(path, 'rb') do |fd|
chunk = nil
size = 0
Expand Down