Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 24, 2025

Release notes

[rn:skip]

What does this PR do?

Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the versions.yml file in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action. The gradle task has been replaced with the updatecli pattern established in #18035

Why is it important/What is the impact to the user?

No user impact, quality of life improvement for logstash devs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

Downgrade java version in versions.yml and run ./gradlew updateJdkVersion to update it back to latest.

Related issues


This is an automatic backport of pull request #17945 done by [Mergify](https://mergify.com).

* Replace buildkite jdk version check w/GH action

Previously a weekly buildkite job would check if there is a newer JDK available
than the one vendored in logstash. This job would fail until someone manually
updated the JDK version in the `versions.yml` file in logstash. This commit
reduces manual intervention by moving the responsibility to a GH action where
there are patterns for creating PRs back to logstash. The action should run
weekly and also be available in the actions UI. It is locked down with the same
permissions as the version bump action.

* Refactor to use updatecli

* Remove gradle task in favor of updatecli

* remove unused file

* Dynamically generate java version lookup

* make pipeline name unique'
'

(cherry picked from commit 2fab5f4)

# Conflicts:
#	catalog-info.yaml
@mergify mergify bot added backport conflicts Detected git conflicts labels Sep 24, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Sep 24, 2025

Cherry-pick of 2fab5f4 has failed:

On branch mergify/bp/8.19/pr-17945
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 2fab5f46.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	deleted:    .buildkite/jdk_availability_check_pipeline.yml
	new file:   .ci/updatecli/bump-java-version.yml
	modified:   .github/workflows/bump-java-version.yml
	modified:   build.gradle
	deleted:    ci/check_jdk_version_availability.sh

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   catalog-info.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added backport conflicts Detected git conflicts labels Sep 24, 2025
@donoghuc donoghuc merged commit 58f3f76 into 8.19 Sep 24, 2025
4 of 5 checks passed
@donoghuc donoghuc deleted the mergify/bp/8.19/pr-17945 branch September 24, 2025 22:04
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @donoghuc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts Detected git conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants