Add google/auth action #3
Conversation
google/auth/action.yml
Outdated
| id: generate-workload-identity-pool-provider-id | ||
| run: | | ||
| HASH=$(echo -n "${GITHUB_REPOSITORY}" | sha256sum | cut -c1-27) | ||
| echo "workload_identity_provider_id=repo-${HASH}" >> "${GITHUB_OUTPUT}" |
There was a problem hiding this comment.
A few questions:
- Do we want to support Windows?
- Should the output be exported too?
There was a problem hiding this comment.
Do we want to support Windows?
Do we have an existing use case for Windows? If not, I'd rather add it when it becomes necessary.
Otherwise, we slightly increase the complexity for no reason.
Should the output be exported too?
I don't see why one would need the workload identity pool id.
I might be wrong, but I think we should only add it if we already see a reason for it. Otherwise, we can always add it later.
P.S.
Of course, if you already know any of this is needed, I'm happy to add it.
There was a problem hiding this comment.
With the latest changes, I actually addressed both points.
- Added outputs to be able to test the output
- Changed the hash-generating script to Python to make it cross-platform compatible.
google/auth/action.yml
Outdated
| HASH=$(echo -n "${GITHUB_REPOSITORY}" | sha256sum | cut -c1-27) | ||
| echo "workload_identity_provider_id=repo-${HASH}" >> "${GITHUB_OUTPUT}" | ||
| shell: bash | ||
| - uses: google-github-actions/auth@v2 |
v1v
left a comment
v1v
left a comment
There was a problem hiding this comment.
OTOH, do you think we should add some kind of tests?
I'll ping you in an internal github issue
v1v
left a comment
v1v
left a comment
There was a problem hiding this comment.
LGTM, I like the approach for testing the action! 💯
* upstream/main: Add google/auth action (elastic#3)
Adds the
google/authaction — an opinionated action to authenticate with the elastic-observability GCP project.