-
Notifications
You must be signed in to change notification settings - Fork 10
fix: allow to disable the output of credentials #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an optional parameter to disable the output of AWS credentials in the auth action to improve performance. The change addresses a performance issue where outputting credentials adds approximately 25 seconds to the action runtime.
Key Changes:
- Added
output-credentialsinput parameter with default value oftrueto maintain backward compatibility - Updated the underlying AWS authentication step to use the configurable parameter instead of hardcoded
true - Updated documentation to reflect the new parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| aws/auth/action.yml | Added new output-credentials input parameter and made the AWS auth step use this configurable value |
| aws/auth/README.md | Added documentation for the new output-credentials parameter |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
This operation is slow and adds 25 seconds to the action runtime.