Skip to content

Conversation

@kuisathaverat
Copy link
Contributor

@kuisathaverat kuisathaverat commented Oct 14, 2025

This operation is slow and adds 25 seconds to the action runtime.

Tue, 14 Oct 2025 08:16:00 GMT Run aws-actions/configure-aws-credentials@a03048d87541d1d9fcf2ecf528a4a65ba9bd7838
Tue, 14 Oct 2025 08:16:01 GMT Assuming role with OIDC
Tue, 14 Oct 2025 08:16:01 GMT Authenticated as assumedRoleId REDACTED
Tue, 14 Oct 2025 08:16:01 GMT Run aws sts get-caller-identity --output text
Tue, 14 Oct 2025 08:16:24 GMT 627286350134	arn:aws:sts::REDACTED
Tue, 14 Oct 2025 08:16:24 GMT ✅ Successfully authenticated to AWS

Copilot AI review requested due to automatic review settings October 14, 2025 08:25
@kuisathaverat kuisathaverat requested a review from a team as a code owner October 14, 2025 08:25
@kuisathaverat kuisathaverat self-assigned this Oct 14, 2025
@kuisathaverat kuisathaverat added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Oct 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an optional parameter to disable the output of AWS credentials in the auth action to improve performance. The change addresses a performance issue where outputting credentials adds approximately 25 seconds to the action runtime.

Key Changes:

  • Added output-credentials input parameter with default value of true to maintain backward compatibility
  • Updated the underlying AWS authentication step to use the configurable parameter instead of hardcoded true
  • Updated documentation to reflect the new parameter

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
aws/auth/action.yml Added new output-credentials input parameter and made the AWS auth step use this configurable value
aws/auth/README.md Added documentation for the new output-credentials parameter

@kuisathaverat kuisathaverat added the changelog:enhancement When you enhance an existing feature label Oct 14, 2025
Copilot AI review requested due to automatic review settings October 14, 2025 08:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@v1v v1v added this pull request to the merge queue Oct 14, 2025
Merged via the queue into main with commit 605dfce Oct 14, 2025
4 checks passed
@v1v v1v deleted the fix/output-credentials-flag branch October 14, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:enhancement When you enhance an existing feature enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants