feat: track IPC events sent from main to service worker #273
+144
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitarth-gg
changed the title
hitarth-gg
commented
Jul 24, 2025
Comment on lines
+141
to
+143
| } else if (details.runningStatus === 'stopped') { | ||
| isInstalledSet.delete(details.versionId); | ||
| } |
There was a problem hiding this comment.
question: once a service worker is stopped and then restarted will it's versionId change to a new one ? If not then this can cause .send to be patched more than once which is problematic.
If versionId remains the same, I can probably remove these 3 lines to fix this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
scopeandversionId.