This repository was archived by the owner on Dec 5, 2022. It is now read-only.
Unpack protocol-link.html #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow, very nice. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in #227 that the Protocol Handler demo was not working in the Mac App Store build. It looks like it is actually not working in any build.
Since the app is packaged in a
.asarfile the link toprotocol-link.htmlneeds to be unpacked since browsers can't read files fromapp.asarsoshell.openExternalwould fail.This pull request moves
protocol-link.htmlto theapp.asar.unpackedfolder so it can be read as a normal file when opened externally.