Skip to content

Conversation

@miniak
Copy link
Contributor

@miniak miniak commented Aug 12, 2023

Description of Change

Follow-up to #37094

Checklist

Release Notes

Notes: Removed deprecated getTrafficLightPosition() and setTrafficLightPosition().

@miniak miniak requested a review from a team as a code owner August 12, 2023 09:08
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 12, 2023
@miniak miniak self-assigned this Aug 12, 2023
@miniak miniak requested a review from zcbenz August 12, 2023 09:09
@miniak miniak added semver/major incompatible API changes no-backport labels Aug 12, 2023
@miniak miniak force-pushed the miniak/traffic-light-position-cleanup branch 2 times, most recently from cafc518 to 2a4595c Compare August 14, 2023 09:37
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Contributor

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@miniak miniak force-pushed the miniak/traffic-light-position-cleanup branch from 2a4595c to 711409f Compare August 19, 2023 12:12
@codebytere codebytere merged commit 90865fa into main Aug 21, 2023
@codebytere codebytere deleted the miniak/traffic-light-position-cleanup branch August 21, 2023 13:58
@release-clerk
Copy link

release-clerk bot commented Aug 21, 2023

Release Notes Persisted

Removed deprecated getTrafficLightPosition() and setTrafficLightPosition().

win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
…htPosition()` (electron#39479)

chore: remove deprecated getTrafficLightPosition() / setTrafficLightPosition()
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
…htPosition()` (electron#39479)

chore: remove deprecated getTrafficLightPosition() / setTrafficLightPosition()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🗑 Complete

Development

Successfully merging this pull request may close these issues.

7 participants