-
Notifications
You must be signed in to change notification settings - Fork 16.7k
docs: add caveats for Electron PipeWire implementation #48242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💖 Thanks for opening this pull request! 💖 Semantic PR titlesWe use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Commit signingThis repo enforces commit signatures for all incoming PRs. PR tipsThings that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
878c92e to
228b944
Compare
|
What is required to get this merged? |
erickzhao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs: lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of the Electron Docs Team
228b944 to
22e2e4f
Compare
|
No Release Notes |
|
I have automatically backported this PR to "39-x-y", please check out #48713 |
Description of Change
The Pipewire Capturer implementation in Electron has some Caveats, but those are only documented in the codebase.
electron/shell/browser/api/electron_api_desktop_capturer.cc
Line 253 in fed7304
electron/shell/browser/api/electron_api_desktop_capturer.cc
Lines 285 to 286 in fed7304
Checklist
Notes: none