Skip to content

Conversation

@byquanton
Copy link
Contributor

@byquanton byquanton commented Sep 2, 2025

Description of Change

The Pipewire Capturer implementation in Electron has some Caveats, but those are only documented in the codebase.

// PipeWire returns a single source, so index is not relevant.

// Some capturers like PipeWire support a single capturer for both screens
// and windows. Use it if possible, treating both as window capture

Checklist

Notes: none

@welcome
Copy link

welcome bot commented Sep 2, 2025

💖 Thanks for opening this pull request! 💖

Semantic PR titles

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Commit signing

This repo enforces commit signatures for all incoming PRs.
To sign your commits, see GitHub's documentation on Telling Git about your signing key.

PR tips

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@byquanton
Copy link
Contributor Author

What is required to get this merged?

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

Copy link

@electron-docs-reviewer electron-docs-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@VerteDinde VerteDinde force-pushed the docs/pipewire-caveats branch from 228b944 to 22e2e4f Compare October 28, 2025 19:17
@erickzhao erickzhao added the target/39-x-y PR should also be added to the "39-x-y" branch. label Oct 28, 2025
@VerteDinde VerteDinde merged commit 1d3cc9d into electron:main Oct 28, 2025
30 checks passed
@electron-release-clerk
Copy link

No Release Notes

@trop
Copy link
Contributor

trop bot commented Oct 28, 2025

I have automatically backported this PR to "39-x-y", please check out #48713

@trop trop bot added in-flight/39-x-y merged/39-x-y PR was merged to the "39-x-y" branch. and removed target/39-x-y PR should also be added to the "39-x-y" branch. in-flight/39-x-y labels Oct 28, 2025
TheCommieAxolotl pushed a commit to TheCommieAxolotl/electron that referenced this pull request Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation 📓 merged/39-x-y PR was merged to the "39-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants