-
Notifications
You must be signed in to change notification settings - Fork 839
Don't ignore verification UI tests #7295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work.
Just added small comments
vector-app/src/androidTest/java/im/vector/app/VerifySessionInteractiveTest.kt
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
@BillCarsonFr can you handle this PR please? A test is not passing. |
Amit Kumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Type of change
Content
Motivation and context
UI tests related to verification has been ignored so it was hard to verify any behavior about session verification. This PR enables them so we can confirm that the UI changes are working as expected.
WRT -> #7197
Tests
To test this PR, run this command ->
:vector-app:connectedGplayDebugAndroidTest
All instrumented tests should pass.
Tested devices
Checklist