Skip to content

Conversation

@devonh
Copy link
Member

@devonh devonh commented Nov 6, 2024

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@devonh devonh requested a review from a team as a code owner November 6, 2024 17:00
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 17:01 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 17:02 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 17:13 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 17:31 Active
devonh and others added 5 commits November 6, 2024 17:41
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 17:42 Active
@anoadragon453
Copy link
Member

this container build job can also be removed, but that can be done in a separate PR/release.

@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 17:46 Active
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, once CI passes.

@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 18:11 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 18:30 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 18:33 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 6, 2024 19:04 Active
@devonh devonh merged commit eda735e into develop Nov 6, 2024
42 checks passed
@devonh devonh deleted the devon/deprecate-py38 branch November 6, 2024 19:36
bmarty added a commit to element-hq/element-android that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants