-
Notifications
You must be signed in to change notification settings - Fork 18
Add option to use cache when download pretrained files #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This makes the usage simplier and faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also make a HEAD request and compare E-tag, since for revision like main
the file may change, that's what we do in the other project. But the reference implementation doesn't do it either, so it's probably fine, we can revisit if we run into any actual issues!
Oh actually, having a brief look at the |
@jonatanklosko humm, interesting! I think I'm going to move this responsibility to the HTTP client then 🤔 |
Actually maybe not. Haha. I will be out for the next two hours, but I change this after I'm back. |
@jonatanklosko it's not pretty but now works with E-tags :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but looks good to me!
🚢 🐈 |
This makes the usage simpler and faster.