Add riscv64gc-unknown-linux-gnu for RISC-V Nerves devices #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerves supports 64-bit RISC-V devices. One of these is the MangoPi MQ Pro which is being used as an alternative to the Raspberry Pi. Currently it's much, much easier to use precompiled Rust binaries with Nerves. In fact, manually crosscompiling `tokenizers` with Nerves doesn't work due to a compiler error deep in the Rust build. This adds the riscv64gc target to make it possible to use `tokenizers` with Nerves on 64-bit RISC-V devices as easy as 64-bit ARM ones. This, in turn, enables Bumblebee support.
polvalente
approved these changes
Dec 21, 2022
|
@philss do you think we will have problems precompiling with this or are we fine? |
|
@josevalim this one is well supported by cross, and is in Tier 2, so we should be fine 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nerves supports 64-bit RISC-V devices. One of these is the MangoPi MQ Pro which is being used as an alternative to the Raspberry Pi. Currently it's much, much easier to use precompiled Rust binaries with Nerves. In fact, manually crosscompiling
tokenizerswith Nerves doesn't work due to a compiler error deep in the Rust build.This adds the riscv64gc target to make it possible to use
tokenizerswith Nerves on 64-bit RISC-V devices as easy as 64-bit ARM ones. This, in turn, enables Bumblebee support.See also the discussion at philss/rustler_precompiled#44 about trying out
riscv64gc-unknown-linux-gnuhere before adding it as a default inrustler_precompiled.