Allow colon to be escaped when building the path segments #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 30, 2025
josevalim
reviewed
Sep 30, 2025
josevalim
reviewed
Sep 30, 2025
|
Looks great. I've added a comment about also escaping |
Co-authored-by: José Valim <[email protected]>
|
Sorry, I meant to say update the documentation of Plug.Router. I have edited above. |
|
@josevalim Updated both the readme, and allowed * to be escaped, thank you! :) |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on this issue from phoenix: phoenixframework/phoenix#6436
I've tried to change as little as the original code as possible to not introduce regressions, hence the new clause match.
@josevalim If there is any documentation that you would like to be updated, point me in that direction and I'll update it